aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* output_buffer: don't split framesMax Kellermann2008-10-233-1/+16
| | | | | | | Splitting a frame between two buffer chunks causes distortion in the output. MPD used to assume that the chunk size 1020 would never cause splitted frames, but that isn't the case for 24 bit stereo (127.5 frames), and even less for files with even more channels.
* stored_playlist: don't map files outside the databaseMax Kellermann2008-10-231-2/+3
| | | | | | Don't attempt to map paths which are already absolute with map_song_fs(): check with song_in_database() instead of song_is_file().
* stored_playlist: emit idle event on deleteMax Kellermann2008-10-231-0/+1
| | | | The "rm" command did not send notifications to idle clients. Add it.
* stored_playlist: renamed and moved spl_delete() to stored_playlist.cMax Kellermann2008-10-235-17/+19
| | | | The function deletePlaylist() shouldn't be in playlist.c.
* stored_playlist: spl_load() returns GPtrArrayMax Kellermann2008-10-233-146/+75
| | | | | Don't use our deprecated linked list library, use GLib's GPtrArray instead.
* command: check over/underflows in check_int()Max Kellermann2008-10-231-2/+13
| | | | | The "long" result of strtol() was implicitly casted down to a 32 bit integer. Add some range checking instead.
* command: added check_unsigned() / check_bool()Max Kellermann2008-10-231-13/+57
| | | | | | | Many command arguments must not be negative; add a separate parser/checker function for that. For the same reason, add check_bool(). This eliminates two strange special cases handlers from check_int().
* stored_playlist: unsigned index argumentsMax Kellermann2008-10-232-6/+6
| | | | | | Pass index arguments as unsigned integers. They must not be negative, and even if some caller accidently passes -1, it won't pass the bound checks (since it's now 2**32-1).
* playlist: unsigned integersMax Kellermann2008-10-233-150/+131
| | | | | | There are some integers which have a "magic" -1 value which means "undefined" or "nothing". All others can be converted to unsigned, since they must not contain a negative number.
* command: use the bool datatype instead of intMax Kellermann2008-10-222-51/+54
| | | | | Instead of returning 0 for success and -1 for failure, return true or false. This seems more natural.
* command: converted COMMAND_RETURN_* macros to enumMax Kellermann2008-10-222-168/+173
| | | | | | | | Also add names for "error" and "ok". I don't like passing anonymous integer codes around. This is not yet complete: lots of functions (e.g. in playlist.c) follow the same convention of -1/0, and these have to be adapted, too.
* command: replaced "goto" with "break"Max Kellermann2008-10-221-2/+2
| | | | http://xkcd.com/292/
* command: no CamelCaseMax Kellermann2008-10-224-238/+260
| | | | Eliminate CamelCase in all public and static functions.
* command: removed CommandHandlerFunction typedefMax Kellermann2008-10-221-3/+1
| | | | | The typedef CommandHandlerFunction is only used once. Move its type into the command struct.
* ack: converted ACK_ERROR_* macros to enumMax Kellermann2008-10-223-16/+18
|
* stored_playlist: send timestampsMax Kellermann2008-10-222-0/+14
| | | | | Send last modification timestamps to the client. This allows the client to see when another client modifies a stored playlist.
* command: added command "listplaylists"Max Kellermann2008-10-222-0/+24
| | | | | "listplaylists" returns a list of all stored playlists. This command seems more elaborate than listing them below "lsinfo".
* command: added print_spl_list()Max Kellermann2008-10-223-22/+18
| | | | | The function print_spl_list() replaces the old function lsPlaylists() from ls.c.
* stored_playlist: added spl_list()Max Kellermann2008-10-223-73/+106
| | | | | | spl_list() provides an interface for enumerating all stored playlists. This separates the internal playlist logic from the protocol specific function lsPlaylists().
* stored_playlist: spl_append_uri() returns enum playlist_resultMax Kellermann2008-10-222-5/+4
| | | | | The return value of spl_append_uri() was somewhat buggy: some branches returned ACK_* values, and some an enum playlist_result. Unify this.
* stored_playlist: de-CamelCase moved functionMax Kellermann2008-10-223-6/+6
| | | | | Rename addToStoredPlaylist() to spl_append_uri(), and remove the clearStoredPlaylist() macro.
* stored_playlist: moved functions from playlist.cMax Kellermann2008-10-224-32/+26
| | | | | | The two functions clearStoredPlaylist() and addToStoredPlaylist() don't belong into playlist.c. clearStoredPlaylist() was a wrapper for spl_clear(), and is converted into a CPP macro for now.
* stored_playlist: no CamelCaseMax Kellermann2008-10-225-34/+39
| | | | Renamed all public functions, prefix is "spl_".
* renamed storedPlaylist.c to stored_playlist.cMax Kellermann2008-10-226-8/+8
| | | | No CamelCase in file names.
* command: added "commands" array instead of registering manuallyMax Kellermann2008-10-221-193/+145
| | | | | | The list of commands is known at compile time. Instead of creating a linked list on startup, we can just register all commands in a static sorted array.
* command: make command pointers constantMax Kellermann2008-10-221-12/+13
| | | | | | The command pointers which are passed around aren't being modified - in fact, no command pointer must be modified once it has been added to the commandList.
* command: renamed CommandEntry to struct commandMax Kellermann2008-10-221-12/+10
| | | | No CamelCase and no struct typedefs.
* pcm_utils: added pcm_convert_init()Max Kellermann2008-10-214-2/+9
| | | | | | Instead of manually calling memset(0) on the pcm_convert_state struct, client code should use a library function from pcm_utils.c. This way, we can change the semantics of the struct easily.
* pcm_utils: no CamelCaseMax Kellermann2008-10-215-88/+89
| | | | Renamed all functions which were still in CamelCase.
* pcm_utils: renamed ConvState to struct pcm_convert_stateMax Kellermann2008-10-215-9/+12
| | | | No CamelCase, and a struct instead of a typedef.
* ffmpeg: don't pass pointer as hexadecimal stringMax Kellermann2008-10-211-20/+27
| | | | | | | | | | | | | | Casting a pointer to some sort of integer and formatting it into a string isn't valid. A pointer derived from this hex string won't work reliably. Since ffmpeg doesn't provide a nice API for passing our pointer, we have to think of a different hack: ffmpeg passes the exact URL pointer to mpdurl_open(), and we can make this string part of a struct. This reduces the problem to casting the string back to the struct. This is still a workaround, but this is "sort of portable", unless the ffmpeg people start messing with the URL pointer (which would be valid according to the API definition).
* ffmpeg: link with libavutilMax Kellermann2008-10-211-1/+1
| | | | Since ffmpeg svn r13528, you have to link with libavutil manually.
* ffmpeg: detect which ffmpeg headers should be includedMax Kellermann2008-10-212-0/+17
| | | | | | | | | Since ffmpeg svn r12865, you have to include libavcodec/avcodec.h instead of avcodec.h. This cannot be checked at compile time, instead we have to add a check to configure.ac. Viliam's original ffmpeg plugin was based on the newer ffmpeg library, while my Debian installation had the older version. My attempt to correct his include statements wasn't correct after all.
* update: fix multiple deletes from *vec iteratorsEric Wong2008-10-212-2/+10
| | | | | | | | | | | {song,dir}vec_for_each each failed to gracefully handle deleted files when iterating through. While we were thread-safe, we were not safe within the calling thread. If a callback we passed caused sv->nr to shring, our index would still increment; causing files to stay in the database. A way to test this is to remove 10 or so contiguous songs from a >10 song directory.
* dirvec: introduce locking for all iteratorsEric Wong2008-10-211-6/+25
| | | | | | | Like the songvec nr_lock, only one lock is used for all traversals since they're rarely changed. This only projects traversals, but not the individual structures themselves.
* {dir,song}vec: these structs are constEric Wong2008-10-212-2/+2
| | | | We definitely don't modify them here.
* dirvec: add dirvec_for_each iteratorEric Wong2008-10-212-0/+19
| | | | This will make it easier to introduce locking
* path: removed pathcpy_trunc()Max Kellermann2008-10-203-24/+2
| | | | There was only one user of pathcpy_trunc(), which can be eliminated.
* path: replaced parent_path() with g_path_get_dirname()Max Kellermann2008-10-203-42/+7
| | | | Again, GLib's version is more robust than ours.
* path: replaced mpd_basename() with g_path_get_basename()Max Kellermann2008-10-206-29/+30
| | | | | | GLib's g_path_get_basename() is much more reliable than mpd_basename(). The latter could be tricked into an assertion failure.
* signal_check.c: don't use leading underscoresMax Kellermann2008-10-201-8/+8
| | | | | Identifiers with two leading underscores are reserved for the C compiler's internal use. Don't use them in the source.
* mapper: don't return database path with leading slashMax Kellermann2008-10-191-1/+1
| | | | | Due to an off-by-one bug in map_fs_to_utf8(), the function returned database paths with a leading slash.
* configure.ac: use libmikmod-config instead of pkg-configAndrzej Rybczak2008-10-181-3/+8
| | | | [mk: use AC_SUBST instead of appending to MPD_CFLAGS / MPD_LIBS]
* listen: fix "struct ucred" checkAndrzej Rybczak2008-10-181-3/+3
| | | | The macro name is HAVE_STRUCT_UCRED, not HAVE_UCRED.
* input_stream: don't declare method typedefsMax Kellermann2008-10-181-14/+8
| | | | | The typedefs aren't using by anybody but struct input_stream. Remove them and declare the method type within struct input_stream.
* ffmpeg: make internal functions staticMax Kellermann2008-10-181-22/+12
| | | | | The mpdurl_* code is internal, don't expose them. Also don't initialize struct members with NULL.
* Makefile.am: require automake 1.9Max Kellermann2008-10-183-3/+3
| | | | | | | | With heavy use of conditionals, I broke Makefile.am for the ancient automake version 1.6. Instead of supporting this automake version forever, I'm removing support for it now. Since automake isn't required on the build machine, nobody should have a serious problem with that.
* reverted package name to "mpd"Max Kellermann2008-10-171-1/+1
| | | | | Since mpd-mk has become the "official" MPD, the rename from commit ba892cbc can be reverted.
* client: converted permissions to unsignedMax Kellermann2008-10-175-22/+22
| | | | client->permission is a bit set, and should be unsigned.
* client: eliminate variable "left" in client_write()Max Kellermann2008-10-171-5/+5
| | | | Reduce two temporary variables to only one.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 12:26:05 +0000