aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* removed internal copy of libmp4ffMax Kellermann2008-10-2516-4653/+6
| | | | | | MPD shouldn't integrate sources of other libraries. Since libmp4ff is part of libfaad, we should remove the old copy from src/mp4ff and link with the current version from libfaad instead.
* pulse: force 16 bit audio sample formatMax Kellermann2008-10-251-5/+3
| | | | | | | | | PA_SAMPLE_S16NE is the only sample format which is suported by both MPD and pulseaudio. Unfortunately, pulse does not accept 24 bit samples. Instead of bailing out with an error message, we should tell the MPD core to convert all samples to 16 bit for pulse.
* AUTHORS: Eric Wong is a former developerEric Wong2008-10-251-3/+2
| | | | | Eric is too busy with other projects and will remain inactive indefinitely.
* player: don't clear command before do_play() returnsMax Kellermann2008-10-241-1/+0
| | | | | | | | | This bug caused the audio output devices to stay open, although MPD wasn't playing: quitDecode() resetted player_control.command, assuming that the command was STOP. This way, player_task() didn't see the CLOSE_AUDIO command, and the device was kept open. Don't clear player_control.command in quitDecode().
* remove unused sourcesMax Kellermann2008-10-242-221/+0
| | | | These are results from failed merges which I didn't notice.
* jack: support for 24 bit samplesMax Kellermann2008-10-241-1/+32
| | | | | | When the audio source provides 24 bit samples, don't bother to convert (lossily) them to 16 bit before jack's floating point conversion - go directly from 24 bit to float.
* jack: moved code to jack_write_samples_16()Max Kellermann2008-10-241-14/+42
| | | | Move sample format dependent code to a separate function.
* jack: eliminated CamelCaseMax Kellermann2008-10-241-73/+76
| | | | | Renamed all variables and functions. Add the prefix "mpd_jack_" to function names.
* jack: added assertions against partial framesMax Kellermann2008-10-241-0/+2
| | | | We must never pass partial frames. Added assertions to debug this.
* jack: optimize local variablesMax Kellermann2008-10-241-9/+8
| | | | | Merge the variables "avail_data" and "avail_frames" into "available". Both variables are never used at the same time.
* jack: lockless data transfer to jack threadMax Kellermann2008-10-241-47/+15
| | | | | | | | The JACK documentation postulates that the process() callback must not block, therefore locking is forbidden. Anyway, the old code was racy. Remove all locks, and don't wait for more data to become available - just send to the port what is already in the buffer.
* jack: partial writes to ring bufferMax Kellermann2008-10-241-15/+15
| | | | | | Don't wait until there is room for the full data chunk passed to jack_playAudio(). Try to incrementally send as much as possible into the ring buffer.
* jack: added constant "frame_size"Max Kellermann2008-10-241-1/+2
| | | | | | Don't hard-code a frame size of "4" (16 bit stereo), calculate the sample size from sizeof(*buffer), and create the constant "frame_size".
* jack: fix indentationMax Kellermann2008-10-241-33/+33
| | | | Indent with tabs.
* pcm_resample: support for libsamplerate < 0.1.3Max Kellermann2008-10-242-0/+25
| | | | | libsamplerate 0.1.2 didn't have the 32 bit <-> float conversion routines. Emulate them in case they aren't supported.
* player: don't send partial frames of silenceMax Kellermann2008-10-231-1/+7
| | | | | | Another partial frame fix: the silence buffer was 1020 bytes, which had room for 127.5 24 bit stereo frames. Don't send the partial last frame in this case.
* pcm_utils: added 24 bit conversion functionsMax Kellermann2008-10-231-0/+108
| | | | | | 24 bit output is as important as 16 bit output. Provide a pcm_convert() implementation which can convert to 24 bit with as little quality loss as possible.
* pcm_utils: generic pcm_convert_size() implementationMax Kellermann2008-10-231-21/+2
| | | | | | The old pcm_convert_size() ignored most of the destination format, e.g. it did not check its sample size, and assumed it is 16 bit. Simplify and universalize it by using audio_format_frame_size().
* pcm_utils: moved code to pcm_convert_16()Max Kellermann2008-10-231-21/+39
| | | | | pcm_convert() converted only to 16 bit. To be able to support other sample sizes, move that 16 bit specific code to a separate function.
* pcm_channels: added 24 bit implementationsMax Kellermann2008-10-232-0/+84
| | | | | The 24 bit implementation is mostly copy'n'paste of the 16 bit version, except that the data type is int32_t instead of int16_t.
* pcm_utils: moved channel conversion functions to pcm_channels.cMax Kellermann2008-10-234-82/+138
| | | | Separate code from pcm_utils.c to keep it small and simple.
* pcm_resample: implemented 24 bit resamplingMax Kellermann2008-10-233-0/+94
| | | | | | | Similar to pcm_resample_16(), implement pcm_resample_24(). The 24 bit implementation is very similar, but it uses src_int_to_float_array() instead of src_short_to_float_array() before sending data to libsamplerate.
* pcm_resample: moved code to pcm_resample_set()Max Kellermann2008-10-231-29/+40
| | | | | A future patch will implement a 24 bit resampler. To unify code, move code which can be shared to a separate function.
* pcm_resample: eliminated "sample" local variablesMax Kellermann2008-10-231-9/+3
| | | | | Copy from source to destination buffer directly, don't use the temporary variables "lsample" and "rsample".
* pcm_resample: don't resample partial samplesMax Kellermann2008-10-232-0/+9
| | | | | Added assertions which ensure that there are no partial samples in the source buffer.
* pcm_resample: don't hard-code sample sizeMax Kellermann2008-10-232-4/+4
| | | | | | Use sizeof(sample) instead of hard-coding "2". Although we're in 16 bit right now, this will make code sharing easier when we support other sample sizes.
* pcm_utils: moved code to pcm_resample.cMax Kellermann2008-10-238-176/+308
| | | | | | Separate the resampling code from the rest of pcm_utils.c. Create two sub-libraries: pcm_resample_libsamplerate.c and pcm_resample_fallback.c.
* command: fix boolean value parserMax Kellermann2008-10-231-1/+1
| | | | | Due to a logic error, no value was valid for the boolean value parser. Replace "||" with "&&".
* mp3: send 24 bit PCM dataMax Kellermann2008-10-231-63/+24
| | | | | | | libmad produces samples of more than 24 bit. Rounding that down to 16 bits using dithering makes those people lose quality who have a 24 bit capable sound device. Send 24 bit PCM data, and let the receiver decide whether to apply 16 bit dithering.
* mp3: use sizeof(sample) instead of hard-coded "2"Max Kellermann2008-10-231-2/+3
| | | | | We are going to convert the code to 24 bit; don't hard-code a sample size of 2 bytes.
* pcm_dither: added generic 24 to 16 bit ditheringMax Kellermann2008-10-235-8/+139
| | | | | Copied and adapted code from the mp3 decoder plugin. This library now replaces the old and low-quality function pcm_convert_24_to_16().
* audio: allow 24 and 8 bit outputMax Kellermann2008-10-231-4/+2
| | | | | | | I added 24 bit support a while ago, but it wasn't possible to force 24 bit output. Add 24 and 8 bit to the list of allowed sample sizes. Although 8 bit audio isn't as widely used as 24 bit, there is no reason to exclude it.
* output_buffer: don't split framesMax Kellermann2008-10-233-1/+16
| | | | | | | Splitting a frame between two buffer chunks causes distortion in the output. MPD used to assume that the chunk size 1020 would never cause splitted frames, but that isn't the case for 24 bit stereo (127.5 frames), and even less for files with even more channels.
* stored_playlist: don't map files outside the databaseMax Kellermann2008-10-231-2/+3
| | | | | | Don't attempt to map paths which are already absolute with map_song_fs(): check with song_in_database() instead of song_is_file().
* stored_playlist: emit idle event on deleteMax Kellermann2008-10-231-0/+1
| | | | The "rm" command did not send notifications to idle clients. Add it.
* stored_playlist: renamed and moved spl_delete() to stored_playlist.cMax Kellermann2008-10-235-17/+19
| | | | The function deletePlaylist() shouldn't be in playlist.c.
* stored_playlist: spl_load() returns GPtrArrayMax Kellermann2008-10-233-146/+75
| | | | | Don't use our deprecated linked list library, use GLib's GPtrArray instead.
* command: check over/underflows in check_int()Max Kellermann2008-10-231-2/+13
| | | | | The "long" result of strtol() was implicitly casted down to a 32 bit integer. Add some range checking instead.
* command: added check_unsigned() / check_bool()Max Kellermann2008-10-231-13/+57
| | | | | | | Many command arguments must not be negative; add a separate parser/checker function for that. For the same reason, add check_bool(). This eliminates two strange special cases handlers from check_int().
* stored_playlist: unsigned index argumentsMax Kellermann2008-10-232-6/+6
| | | | | | Pass index arguments as unsigned integers. They must not be negative, and even if some caller accidently passes -1, it won't pass the bound checks (since it's now 2**32-1).
* playlist: unsigned integersMax Kellermann2008-10-233-150/+131
| | | | | | There are some integers which have a "magic" -1 value which means "undefined" or "nothing". All others can be converted to unsigned, since they must not contain a negative number.
* command: use the bool datatype instead of intMax Kellermann2008-10-222-51/+54
| | | | | Instead of returning 0 for success and -1 for failure, return true or false. This seems more natural.
* command: converted COMMAND_RETURN_* macros to enumMax Kellermann2008-10-222-168/+173
| | | | | | | | Also add names for "error" and "ok". I don't like passing anonymous integer codes around. This is not yet complete: lots of functions (e.g. in playlist.c) follow the same convention of -1/0, and these have to be adapted, too.
* command: replaced "goto" with "break"Max Kellermann2008-10-221-2/+2
| | | | http://xkcd.com/292/
* command: no CamelCaseMax Kellermann2008-10-224-238/+260
| | | | Eliminate CamelCase in all public and static functions.
* command: removed CommandHandlerFunction typedefMax Kellermann2008-10-221-3/+1
| | | | | The typedef CommandHandlerFunction is only used once. Move its type into the command struct.
* ack: converted ACK_ERROR_* macros to enumMax Kellermann2008-10-223-16/+18
|
* stored_playlist: send timestampsMax Kellermann2008-10-222-0/+14
| | | | | Send last modification timestamps to the client. This allows the client to see when another client modifies a stored playlist.
* command: added command "listplaylists"Max Kellermann2008-10-222-0/+24
| | | | | "listplaylists" returns a list of all stored playlists. This command seems more elaborate than listing them below "lsinfo".
* command: added print_spl_list()Max Kellermann2008-10-223-22/+18
| | | | | The function print_spl_list() replaces the old function lsPlaylists() from ls.c.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 10:37:51 +0000