aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* renamed the "mod" decoder plugin to "mikmod"Max Kellermann2009-01-243-5/+5
| | | | | We have two mod plugins now: modplug and mod. Rename the latter to a more useful name.
* tag_id3: added MusicBrainz tag supportMax Kellermann2009-01-241-0/+79
| | | | | | Added support for the MusicBrainz TXXX tags, documented on: http://musicbrainz.org/doc/MusicBrainzTag
* tag_id3: always allocate tag objectMax Kellermann2009-01-241-30/+27
| | | | | Save some code: always allocate the tag object, and free it when it turns out to be empty.
* tag: added support for MusicBrainz tagsMax Kellermann2009-01-243-1/+14
| | | | | | | | | Added all important id tags from the MusicBrainz wiki: http://musicbrainz.org/doc/MusicBrainzTag This should automatically enable its suport in the vorbis and flac decoder plugins.
* modplug: removed EOF check from the while loopMax Kellermann2009-01-241-2/+4
| | | | | EOF is checked by input_stream_read() (decoder_read() here). Don't do it twice. The check was wrong anyway, it was reversed.
* modplug: check for input_stream errorsMax Kellermann2009-01-241-2/+8
| | | | | When input_stream_read() returns 0, and input_stream_eof() returns false, an I/O error has occured. Skip this song.
* modplug: use size_t instead of int for buffer sizesMax Kellermann2009-01-241-1/+1
|
* modplug: check size limit before appending new bufferMax Kellermann2009-01-241-4/+4
| | | | | Don't enlarge the GByteArray when the size limit may overflow in this operation; check the size limit first.
* modplug: use GByteArray.len, remove total_lenMax Kellermann2009-01-241-4/+2
| | | | | The local variable "total_len" is superfluous because GByteArray always knows its size.
* modplug: unknown size is -1; check for empty fileMax Kellermann2009-01-241-5/+12
| | | | | | The input_stream API sets size to -1 when the size of the resource is not known. The modplug decoder checked for size==0, which would be an empty file.
* modplug: header cleanupMax Kellermann2009-01-241-2/+0
| | | | Don't include utils.h and log.h, they are relics from the past.
* modplug: define G_LOG_DOMAINMax Kellermann2009-01-241-0/+3
| | | | Make sure that log messages are decorated correctly.
* modplug: declare constants as enumMax Kellermann2009-01-241-4/+6
| | | | Don't write CPP if you can write C.
* modplug: use only decoder_read(), not input_stream_read()Max Kellermann2009-01-241-5/+1
| | | | | | You are allowed to call decoder_read() with decoder==NULL. It is a convenience function provided by the decoder API. Don't manually fall back to input_stream_read().
* locate: added locate_item_list_casefold()Max Kellermann2009-01-244-11/+22
| | | | | Merged casefolding code from two locations into this one library function.
* queue_print, dbUtils: use struct locate_item_listMax Kellermann2009-01-247-74/+58
| | | | | Changed the function prototypes to get locate_item_list objects instead of num_items/items.
* locate: added struct locate_item_listMax Kellermann2009-01-245-87/+111
| | | | | Instead of passing two parameters around (number of items, array of items), combine both in a variable size struct.
* locate: initialize the whole visited_types arrayMax Kellermann2009-01-241-2/+6
| | | | | The declaration initialized only the first element. Initialize the whole array with memset() instead.
* locate: use bool instead of intMax Kellermann2009-01-242-33/+33
| | | | Use the C99 bool type instead of integer values (1/0 or 0/-1).
* locate: no CamelCaseMax Kellermann2009-01-245-89/+76
| | | | Renamed functions and variables.
* queue_print: use new_items instead of itemsMax Kellermann2009-01-241-1/+1
| | | | Fix a typo in one of the previous patches.
* playlist: removed locate functions to queue_print.cMax Kellermann2009-01-245-46/+45
| | | | Now playlist.c does not contain any protocol specific code anymore.
* locate: renamed LocateTagItem to "struct locate_item"Max Kellermann2009-01-247-60/+70
| | | | No CamelCase and no typedefs.
* command: use queue_print_*()Max Kellermann2009-01-244-82/+51
| | | | | Replaced several wrapper functions from playlist.c, and make command.c use the queue print functions directly.
* playlist: added playlist_get_queue()Max Kellermann2009-01-242-0/+12
| | | | | To allow code outside playlist.c to access the "queue" object, provide a function which returns a const pointer.
* playlist: renamed the Playlist typedef to "struct playlist"Max Kellermann2009-01-242-3/+3
| | | | No typedefs.
* playlist: moved stopOnError and errorCount into struct playlistMax Kellermann2009-01-242-11/+23
| | | | Moved the 2 remaining global variables into the playlist struct.
* modplug: change settings before loading a fileAndrzej Rybczak2009-01-241-6/+8
| | | | | alternative settings must be set before the file is loaded, otherwise they won't be respected.
* command: eliminate gcc warningLaszlo Ashin2009-01-241-1/+1
| | | | | Argument cmd of function command_available() is not used if mpd was configured without sqlite.
* commands: don't advertise "sticker" unless configuredMax Kellermann2009-01-231-1/+13
| | | | | In the return value of the "commands" command, don't list the "sticker" command if no sticker file is configured.
* playlist: restore random mode after playlist is loadedMax Kellermann2009-01-231-8/+6
| | | | | | | When the playlist was loaded from the state file, the order numbers were the same as the positions. In random mode, we need to shuffle the queue order. To accomplish that, call setPlaylistRandomStatus() at the end of readPlaylistState(), and do a fresh shuffle.
* playlist: removed song_id_to_position()Max Kellermann2009-01-231-12/+7
| | | | song_id_to_position() is only a wrapper for queue_id_to_position().
* playlist: fix "clear" crash in random modeMax Kellermann2009-01-231-0/+5
| | | | | | | When MPD is not playing while in random mode, and the client issues the "clear" command, MPD crashes in stopPlaylist(), or more exactly, in queue_order_to_position(-1). Exit from stopPlaylist() if MPD isn't playing.
* song: include cleanupMax Kellermann2009-01-231-2/+0
| | | | Removed unused includes.
* playlist: moved saving/loading code to queue_save.cMax Kellermann2009-01-234-26/+125
| | | | | Create a new library which saves/loads the queue to/from the state file.
* playlist: moved PlaylistInfo() to playlist_print.cMax Kellermann2009-01-236-32/+86
| | | | | | PlaylistInfo() (notice the capital 'P') sends a stored playlist to the client. Move it to a separate library, where all the code which glues the playlist and the MPD protocol together will live.
* playlist: moved some printing code to queue_print.cMax Kellermann2009-01-234-32/+142
| | | | | Moved protocol printing functions which operate on the queue to queue_print.c.
* playlist: pass const pointers to search functionsMax Kellermann2009-01-232-19/+17
| | | | The LocateTagItem objects are not modified.
* playlist: removed swapSongs()Max Kellermann2009-01-231-8/+4
| | | | swapSongs() is only a wrapper for queue_swap().
* playlist: don't unpause on deleteMax Kellermann2009-01-232-1/+4
| | | | | When you delete a song from the playlist which was paused, MPD forgot that it was paused and started playing the next song.
* queue: update moved song versionsMax Kellermann2009-01-231-0/+1
| | | | This patch fixes a regression introduced by commit aa9ffc.
* playlist: added source commentsMax Kellermann2009-01-232-5/+147
| | | | | | The playlist.c source is currently quite hard to understand. I have managed to wrap my head around it, and this patch attempts to explain it to the next guy.
* playlist: assert in playPlaylistIfPlayerStopped()Max Kellermann2009-01-231-15/+15
| | | | | | The function playPlaylistIfPlayerStopped() is only called when the player thread is stopped. Converted that runtime check into an assertion, and remove one indent level.
* playlist: don't shuffle if not in random modeMax Kellermann2009-01-231-1/+1
| | | | | | One of the previous patches removed the "random" mode check from nextSongInPlaylist(), which caused a shuffle whenever MPD wrapped to the first song in "repeat" mode. Re-add that "random" check.
* playlist: removed unreachable "playing" checkMax Kellermann2009-01-231-11/+7
| | | | | | In playPlaylist(), the second "song==-1 && playing" check can never be reached, because at this point, the function has already returned (after unpausing).
* playlist: removed stopOnError flag from playPlaylist()Max Kellermann2009-01-233-10/+10
| | | | All callers pass false. Don't bother to collect that parameter.
* playlist: restart playing in deleteFromPlaylist()Max Kellermann2009-01-231-22/+9
| | | | | | When a song is deleted, start playing the next song immediately, within deleteFromPlaylist(). This allows us to remove the ugly playlist_noGoToNext flag, and the currentSongInPlaylist() function.
* playlist: calculate next song before deleting the current oneMax Kellermann2009-01-231-11/+5
| | | | | | | By calling queue_next_order() before playlist.current is invalidated (by the deletion of a song), we get more robust results, and the code becomes a little bit easier. incrPlaylistCurrent() is unused now, and can be removed.
* playlist: return early from shufflePlaylist()Max Kellermann2009-01-231-23/+24
| | | | | Remove one indent level by returning diretly after the check. This makes the function more readable.
* playlist: replaced playlist_state with flag playlist.playingMax Kellermann2009-01-232-33/+32
| | | | | | There were only two possible states: STOP and PLAY. The code looks a lot easier if we use a bool instead. Move the variable into the playlist struct.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-06 05:33:57 +0000