aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* directory: serialize song deletes from playlist during updateEric Wong2008-10-073-11/+28
| | | | | | | | | | | | | | | | This makes the update code thread-safe and doesn't penalize the playlist code by complicating it with complicated and error-prone locks (and the associated overhead, not everybody has a thread-implementation as good as NPTL). The update task blocks during the delete; but the update task is a slow task anyways so we can block w/o people caring too much. This was also our only freeSong call site, so remove that function. Note that deleting entire directories is not fully thread-safe, yet; as their traversals are not yet locked.
* directory: use songvec_for_each for iteratorsEric Wong2008-10-071-28/+30
| | | | Get rid of songvec_write so we can enforce proper locking
* song: use songvec_for_each() in songvec_print() / songvec_save()Max Kellermann2008-10-072-20/+19
| | | | | songvec_for_each() has locking, use it instead of manually iterating over the songvec items.
* songvec: pass const pointersMax Kellermann2008-10-072-4/+10
| | | | Pass const songvec pointers to songvec_find() and songvec_for_each().
* dbUtils/directory: traverseAllIn forEachSong returns -1 on errorEric Wong2008-10-072-14/+11
| | | | Being consistent with most UNIX functions...
* songvec: lock traversals for thread-safe updates/readsEric Wong2008-10-071-10/+34
| | | | | | | | | | Only one lock is used for all songvec traversals since they're rarely changed. Also, minimize lock time and release it before calling iterator functions since they may block (updateSongInfo => stat/open/seek/read). This lock only protects songvecs (and all of them) during traversals; not the individual song structures themselves.
* songvec: add songvec_for_each iteratorEric Wong2008-10-072-0/+15
| | | | | This is so we can more consistently deal with locking needed for thread-safety in iterator functions.
* song: replace printSong* with song_print_*Eric Wong2008-10-074-14/+14
| | | | | | This make argument order more consistent for iterators. Additionally, these now return ssize_t results for error checking.
* Assert if we don't have song or song->url setEric Wong2008-10-072-4/+10
| | | | song objects cannot exist without a path or URL
* autotools: tidy up make distEric Wong2008-10-063-145/+2
| | | | | | | | * Add missing headers in Makefile.am * remove mp4ff.dsp (Win32 crap) * Add scripts, m4, bs, autogen.sh to allow for hotfixes by the SCM-challenged. (downloading the source via git is NOT a lightweight operation for everybody).
* autotools: add pthreads linker supportEric Wong2008-10-062-0/+279
| | | | | This is needed for people that don't use any of the following: JACK, ALSA, libmikmod, Shout.
* Add .gitignoreEric Wong2008-10-061-0/+35
| | | | | These patterns have been sitting in my private .git/info/exclude files since 2005 because we used to use SVN.
* song: stop storing song_typeEric Wong2008-10-066-27/+22
| | | | | | | We already know if a song is a URL or not based on whether it has parentDir defined or not. Hopefully one day in the future we can drop HTTP support from MPD entirely when an HTTP filesystem comes along and we can access streams via open(2).
* song: don't make the struct packedMax Kellermann2008-10-062-2/+2
| | | | | | The "packed" attribute may have negative side effects on performance. Remove the "packed" attribute, and increase the size of "song.url" to a multiple of the machine word size.
* song: use flex arrays to store song->urlEric Wong2008-10-064-17/+25
| | | | | | Reduce the number of allocations we make, so there's less pressure on the allocator and less overhead to keep track of the allocations in.
* song: get rid of newNullSong()Eric Wong2008-10-063-16/+3
| | | | | It didn't save us any lines of code nor did it do anything useful since we would overwrite everything anyways.
* song: call freeJustSong if newSong failsEric Wong2008-10-061-1/+1
| | | | | There's no reason to scan the playlist for a song we just allocated.
* command: fix return statusEric Wong2008-10-061-17/+8
| | | | | | This got broken when listHandlerFunc was removed. Since we no longer need it and it's confusing, remove processCommandInternal and just use process_command.
* directory: reuse existing directory if found on updateEric Wong2008-10-061-4/+9
| | | | | | | | | Instead of allocating a new one, just reuse an existing one if one is found when rereading the DB. This is a small makes the previous commit work on subdirectories of the root music directory. [1] "song: better handling of existing songs when rereading DB"
* tag: merge clearMpdTag into tag_freeEric Wong2008-10-061-12/+2
| | | | | avoid some redundant clearing logic as well, since the tag is getting freed.
* command: get rid of specialized list handlersEric Wong2008-10-061-88/+67
| | | | | | | | commands should really not behave differently if they're issued inside a command list or not; so stop having special handler functions to deal with them. "update" was the only command that used this functionality and I changed that in the last commit to serialize access.
* directory: simplify list update handling logicEric Wong2008-10-063-111/+83
| | | | | | | | | | | | | | Now the "update" command can be issued multiple times regardless of whether the client is in list mode or not. We serialize the update tasks to prevent updates from trampling over each other and will spawn another update task once the current one is finished updating and reaped. Right now we cap the queue size to 32 which is probably enough (I bet most people usually run update with no argument anyways); but we can make it grow/shrink dynamically if needed. There'll still be a hard-coded limit to prevent DoS attacks, though.
* main_notify: define main_task so we can use it for assertionsEric Wong2008-10-062-1/+6
| | | | | It'll be easier to keep track of what code runs in what task/thread this way.
* directory: streamline deletesEric Wong2008-10-061-17/+15
| | | | | Instead of relying on the shortname, just pass the song pointer to prevent redundant lookups during deletes.
* pcm_utils: 24 bit supportMax Kellermann2008-09-291-0/+67
| | | | | | | Add support for 24 bit PCM samples to all functions. Note that pcm_convertAudioFormat() converts 24 bit samples to 16 bit; to preserve full quality, support for "real" 24 bit conversion should be added.
* pcm_utils: moved code to special 8/16 bit functionsMax Kellermann2008-09-291-72/+93
| | | | | | | Moved code into separate bit specific functions: - pcm_volumeChange() -> pcm_volume_change_X() - pcm_add() -> pcm_add_X() - pcm_convertTo16bit() -> pcm_convert_8_to_16()
* pcm_utils: pass only one buffer size to pcm_mix()Max Kellermann2008-09-293-22/+28
| | | | | | | | | pcm_mix() might overflow the destination buffer if it is smaller than the second buffer. This is ok because the physical buffer size passed by cross_fade_apply() is always big enough, but clutters pcm_mix() with complicated length checks and contains a dangerous buffer overflow pitfall. Simplify pcm_mix()/pcm_add() and pass only the smaller buffer size; let cross_fade_apply() do the memcpy().
* audio_output: added method pause()Max Kellermann2008-09-299-2/+73
| | | | | | | | | | | | pause() puts the audio output into pause mode: if supported, it may perform a special action, which keeps the device open, but does not play anything. Output plugins like "shout" might want to play silence during pause, so their clients won't be disconnected. Plugins which do not support pausing will simply be closed, and have to be reopened when unpaused. This pach includes an implementation for the shout plugin, which sends silence chunks.
* audio_output: added function audio_output_is_pending()Max Kellermann2008-09-292-0/+11
| | | | | | The function audio_output_is_pending() returns whether there is a pending command. This is useful for output plugins as a break condition for longer loops.
* use C99 struct initializersMax Kellermann2008-09-2920-190/+141
| | | | | | The old struct initializers are error prone and don't allow moving elements around. Since we are going to overhaul some of the APIs soon, it's easier to have all implementations use C99 initializers.
* decoder: renamed plugin methodsMax Kellermann2008-09-295-62/+67
| | | | | Why have a "_func" prefix on all method names? Also don't typedef the methods, there is no advantage in that.
* assume stdint.h and stddef.h are availableMax Kellermann2008-09-2911-82/+4
| | | | | | Since we use a C99 compiler now, we can assert that the C99 standard headers are available, no need for complicated compile time checks. Kill mpd_types.h.
* song: converted "type" to enumMax Kellermann2008-09-292-5/+8
| | | | | | Having an enum type is much nicer than an anonymous integer plus CPP macros. Note that the old code didn't save any space by declaring the variable 8 bit, due to padding.
* removed union const_hackMax Kellermann2008-09-292-7/+4
| | | | | The union const_hack is only used at one place in the shout plugin. Remove its global type declaration.
* require a C99 compilerMax Kellermann2008-09-291-1/+1
| | | | | | | C99 will soon have its 10th birthday. Let's not beat the dead C89 horse, and raise the compiler requirements. From now on, we need a C99 compiler. This adds "-std=gnu99" to the GCC compiler options, in case GCC is used.
* switch to C99 types, part IIMax Kellermann2008-09-2917-58/+82
| | | | | Do full C99 integer type conversion in all modules which were not touched by Eric's merged patch.
* Switch to C99 types (retaining compat with old compilers)Eric Wong2008-09-2920-72/+437
| | | | | | | | | | | | | | | Seeing the "mpd_" prefix _everywhere_ is mind-numbing as the mind needs to retrain itself to skip over the first 4 tokens of a type to get to its meaning. So avoid having extra characters on my terminal to make it easier to follow code at 2:30 am in the morning. Please report any new issues you may come across on Free toolchains. I realize how difficult it can be to build/maintain cross-compiling toolchains and I have no intention of forcing people to upgrade their toolchains to build mpd. Tested with gcc 2.95.4 and and gcc 4.3.1 on x86-32.
* allow searching for albums with an empty tagEric Wong2008-09-292-1/+25
| | | | | | | | | | | | | | | | | | | | tfing wrote: > I have quite some files with an empty album tag as they do not come > from a particular album. > > If I want to look for those files and browse them, this happens: > :: nc localhost 6600 > OK MPD 0.12.0 > find album "" > ACK [2@0] {find} too few arguments for "find" > > I'd like to be able to browse those files in a client like gmpc. > So these 2 items would have to be developed: > - list album should report that some files have an empty tag > - it should be possible to search for an empty tag with the find command Patch-by: Marc Pavot ref: http://musicpd.org/mantis/view.php?id=464
* command: don't clobber next list value when preparsingEric Wong2008-09-291-3/+6
| | | | | | | This only breaks "update" under list command mode and no other commands. This can be done more optimally without the extra heap allocation via xstrdup(); but is uncommon enough to not matter.
* directory: isRootDirectory() is a one-linerEric Wong2008-09-291-4/+1
| | | | Improving the signal to noise ratio...
* directory: writeDirectoryInfo propagates errorsEric Wong2008-09-291-21/+19
| | | | | If a write failed, it's a good sign subsequent writes will fail, too, so propgate errors all the way up the stack.
* directory: make it clear that DIRECTORY_MTIME is deprecatedEric Wong2008-09-291-1/+1
| | | | A long time ago in an mpd far away...
* directory: remove "Mp3" referencesEric Wong2008-09-293-22/+22
| | | | | MPD has supported more audio formats than just MP3 for over five years...
* playlist: deleteASongFromPlaylist takes a const Song *Eric Wong2008-09-292-2/+2
| | | | We don't change the song pointer there, either.
* songvec: songvec_delete takes a const Song pointerEric Wong2008-09-292-2/+2
| | | | We don't modify the Song when we delete it
* directory: remove shortname arguments everywhereEric Wong2008-09-291-80/+41
| | | | | | It was a huge confusing mess of parameter passing around and around. Add a few extra assertions to ensure we're handling parent/child relationships properly.
* path: add mpd_basename() functionEric Wong2008-09-292-0/+20
| | | | | | | This is like basename(3) but with predictable semantics independent of C library or build options used. This is also much more strict and does not account for trailing slashes (mpd should never deal with trailing slashes on internal functions).
* directory.h: remove directory_sigChldHandler declEric Wong2008-09-291-2/+0
| | | | | We no longer fork for directory updates, so we no longer have children to reap.
* directory: replace DirectoryList with dirvecEric Wong2008-09-294-197/+175
| | | | | Small memory reduction compared to songvec since most users have much fewer dirs than songs, but still nice to have.
* directory: remove unused CPP definesEric Wong2008-09-291-4/+0
| | | | We no longer for for updates
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-23 22:37:33 +0000