| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Pressing 'l' switches to the file browser (screen_file) and locates
the previously selected song in the server's database.
|
|
|
|
|
|
| |
Don't store a pointer to the song passed to screen_lyrics_switch(),
duplicate it instead. In the long term, it is too unsafe to work with
a foreign pointer.
|
|
|
|
|
| |
Don't repaint the screen after browser_cmd() if another screen has
been selected meanwhile.
|
|
|
|
|
|
| |
Making the function return the index makes it more flexible: those who
want the pointer can use filelist_get(), and the others may use the
index for other purposes.
|
|
|
|
| |
"entity" is not being used after its initial assignment.
|
|
|
|
|
|
|
| |
When calling browser_change_directory() before a filelist was set,
ncmpc would crash due to a NULL pointer dereference. This scenario is
not possible currently, since the open() method allocates the
filelist.
|
|
|
|
| |
Return true/false instead of 0/-1.
|
| |
|
| |
|
|
|
|
| |
First alpha version for the upcoming version 0.12.
|
|
|
|
| |
The new home page is in the MPD wiki.
|
|
|
|
|
| |
Many users love colors. It would be too confusing for them to have
color options in the configuration file, but no color support enabled.
|
| |
|
|
|
|
|
|
|
|
| |
The ChangeLog is useless, because it hasn't been updated in a while,
and due to the nature of git, the log will never be lost.
Switch to automake "foreign" mode, because "gnu" mandates the presence
of ChangeLog.
|
|
|
|
|
| |
Removed the "Upgrading to ncmpc-0.11.0" section from README. Deleted
the TODO file.
|
|
|
|
| |
ncmpc uses C99 features.
|
|
|
|
|
|
| |
Removed the generic GNU installation instructions, nobody will ever
bother to read this lengthy document. Moved installation instructions
from README.
|
| |
|
|
|
|
|
| |
The artist screen has matured, and everybody should have it by
default.
|
|
|
|
| |
screen_play.h was missing in the tarball.
|
| |
|
|
|
|
| |
Added new sources, removed screen_clock.c.
|
| |
|
|
|
|
|
|
|
| |
Fix a NULL pointer dereference and a memory leak: check if
screen_read_password() returns NULL, and don't call
mpd_sendPasswordCommand(NULL) in this case. Free the password
when done.
|
|
|
|
|
|
|
| |
* moved lirc_event to lirc.c and split out the parts that depend on
variables in main.c into three separate functions
* changed keyboard_event accordingly to avoid duplicate code
* merged lirc_event with ncmpc_lirc_get_command
|
| |
|
|
|
|
|
| |
Use one g_utf8_collate() call instead of g_utf8_collate_key() twice
plus strcmp().
|
|
|
|
|
|
| |
No wreadln() caller cares about an empty string. Simplify the callers
by returning NULL instead of an allocated empty string. This fixes
several memory leaks.
|
|
|
|
|
| |
All functions must receive UTF-8 file names. Delete all which still
work with locale strings, and remove the _utf8 suffix from the others.
|
|
|
|
|
|
| |
Don't convert the character set of strings to and from the current
locale. This library cannot know what the strings are going to be
used for, so it should not mess with them.
|
|
|
|
|
| |
Free the old pattern before prompting for a new one. Free the old
filelist object before retrieving the new one.
|
| |
|
|
|
|
|
| |
The function browser_change_directory() did not free the return value
of g_path_get_dirname().
|
|
|
|
| |
Don't allocate and copy memory.
|
|
|
|
| |
The pointer has already been checked for NULL, eliminate that check.
|
|
|
|
|
|
|
| |
To make the ncmpc binary even smaller, you can compile all sources at
once with "--combine -fwhole-program". Unfortunately, automake does
not support this mode. For further experiments, this patch adds a
custom rule which creates the binary named "ncmpc-tiny" this way.
|
|
|
|
| |
Removed $Id$.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disable lots of smaller features which don't have a separate configure
option:
- xterm title
- screen list
- horizontal scrolling
- MPD version number check
- key binding checks
- character set conversion
- bitrate display
- highlighting in the file browser
- completion / history
|
| |
|
|
|
|
|
| |
The source command.h checks for configure.ac options, so it needs to
include config.h.
|
|
|
|
|
| |
Since the GError return value of g_convert_*() is ignored by ncmpc, we
don't need to retrieve it at all.
|
|
|
|
|
| |
Options which are disabled at compile time shouldn't reserve space for
their values in the options struct.
|
|
|
|
| |
Initialize the options struct statically.
|
|
|
|
| |
"reconnect" is always enabled. "debug" code has been removed.
|
| |
|
|
|
|
|
| |
Option --disable-nls disables all NLS features, even if the system
supports it.
|
|
|
|
|
| |
The option --enable-mini disables lots of features, and tries to
create a ncmpc binary which fits on very small machines.
|
| |
|
| |
|
|
|
|
| |
Detect liblircclient with pkg-config.
|