aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* don't initialize sigaction struct twiceMax Kellermann2008-10-031-6/+3
| | | | | Don't reset sa_mask and sa_flags after every sigaction() call. Do it once.
* restart system call after SIGWINCHMax Kellermann2008-10-031-1/+1
| | | | | | Set option SA_RESTART for the SIGWINCH handler. The screen resizer function is called by the glib main loop anyway, no need to interrupt any random system call here.
* typo: ignore SIGPIPE instead of SIGWINCHMax Kellermann2008-10-031-2/+2
| | | | | | | Somehow the "ignore SIGPIPE" patch had a fatal typo: instead of ignoring SIGPIPE, it ignored SIGWINCH. Somehow ncurses managed to hide the bug's symptoms, but a recent patch finally broke it. Repair the typo.
* screen: export the global variable "screen"Max Kellermann2008-10-0314-99/+85
| | | | | screen_t is a singleton. We do not have to pass it around everywhere. Export the one global variable.
* screen: don't pass mpdclient pointer to method paint()Max Kellermann2008-10-039-33/+32
| | | | | None of the paint() implementations acutally uses the mpdclient pointer. Remove it from the method signature.
* screen_play: remember playlistMax Kellermann2008-10-031-18/+20
| | | | | | | Remove the last paint() dependency on the mpdclient pointer: remember a pointer to the playlist object, and don't take it from mpdclient every time we paint. Also add the variable "current_song_id" which is calculated in update().
* screen: removed "painted" flagMax Kellermann2008-10-033-14/+10
| | | | Repaint immediately instead of setting "painted=0".
* removed KEY_RESIZEMax Kellermann2008-10-034-31/+0
| | | | | Since we are handling SIGWINCH, we do not need to handle KEY_RESIZE from ncurses. Remove it.
* screen_search: array index is tag idMax Kellermann2008-10-031-24/+19
| | | | | Save some bytes again: remove search_tag.id, make the array index equal to the tag id.
* don't import mpdclient_finish_command() twiceMax Kellermann2008-10-032-4/+0
| | | | | mpdclient_finish_command() is already imported by mpdclient.h, don't do it again in the sources.
* screen_search: removed the FUTURE macroMax Kellermann2008-10-031-11/+0
| | | | The future is now!
* options: don't initialize with memset(0)Max Kellermann2008-10-031-2/+0
| | | | | Global variables are already initialized with zero when the program starts, don't memset(0) again.
* options: don't pass the "options" pointer aroundMax Kellermann2008-10-035-55/+48
| | | | | Just make everybody use the global "options" variable. This eliminates namespace confusion and the NO_GLOBAL_OPTIONS hack.
* colors: make color support optional at compile timeMax Kellermann2008-10-038-0/+69
| | | | | Default is colors disabled. Those who love colorful terminals have the option to enable it with --enable-colors.
* options: print one big string in --version screenMax Kellermann2008-10-031-9/+9
| | | | | | Instead of calling printf() multiple times for every compile time option, build the whole string at compile time and print it with puts().
* colors: color id is the index of the "colors" arrayMax Kellermann2008-10-032-45/+25
| | | | | The color ids are sequential, and we can save some bytes if we use it for the array index.
* colors: added enum color_tMax Kellermann2008-10-032-17/+19
| | | | | Instead of declaring a bunch of CPP macros, use a C enum for identifying colors.
* code style, indent with tabs XIMax Kellermann2008-10-0319-921/+790
| | | | Follow the same code style als MPD itself.
* screen_artist: better screen titleMax Kellermann2008-10-031-7/+13
| | | | | | The artist screen shouldn't be marked "experimental" anymore. Describe the current state of the screen in the title, instead of always writing "Artist".
* list_window: remove list_window_state_tMax Kellermann2008-10-036-90/+78
| | | | | | | | We do not need to save a stack of list window states. When we return to a parent directory, we just have to find the directory which we come from in the parent list. Note that this patch resets the cursor when going to the root directory, but I think it's not that important, and I will deal with that later.
* filelist: added filelist_find_directory()Max Kellermann2008-10-032-0/+22
| | | | | The function filelist_find_directory() will be useful for the following patch.
* screen_artist: fix reload in "All tracks"Max Kellermann2008-10-031-7/+11
| | | | | | | The variable "album" was set to _("All tracks") when it was empty. When reloading the songs, ncmpc was trying to find an album named "All tracks", which didn't seem to work. Leave "album" in its canonical form and generate the title text on demand.
* charset: pass -1 instead of strlen()Max Kellermann2008-10-031-2/+2
| | | | | The GTK charset functions accept "-1" if the parameter is null terminated.
* support: removed unused function remove_trailing_slash()Max Kellermann2008-10-032-18/+0
|
* use g_basename() instead of basename()Max Kellermann2008-10-036-42/+13
| | | | | g_basename() is always available, no need to implement a fallback. Also use g_path_get_dirname(), g_path_get_basename().
* use g_ascii_isspace() instead of IS_WHITESPACE()Max Kellermann2008-10-032-13/+11
| | | | Don't duplicate code which is already provided by glib.
* use g_ascii_strdown() instead of the custom lowerstr()Max Kellermann2008-10-033-27/+17
| | | | Don't duplicate code which is already provided by glib.
* list_window: removed unused macro "LW_ROW"Max Kellermann2008-10-021-2/+0
|
* screen_browser: added constant playlist_formatMax Kellermann2008-10-021-6/+3
| | | | | Moved the format string for playlist files to the constant "playlist_format".
* fix compiler errors without locale.hMax Kellermann2008-10-023-1/+20
| | | | | The code did not compile when HAVE_LOCALE_H was not set. Also don't compile all that code in charset.c, when there is no locale.h.
* screen_lyrics: character set conversionMax Kellermann2008-10-021-1/+9
| | | | | Convert the lyrics to the current character set before displaying them.
* charset: convert strings with fallbackMax Kellermann2008-10-021-24/+10
| | | | | Use g_convert_with_fallback() for charset conversion, and don't print a status bar message on error.
* charset: charset_init() returns character setMax Kellermann2008-10-023-8/+8
| | | | | Don't pass "noconvert" to charset_init(). Let charset_init() determine that with g_get_charset() and return its name.
* charset: renamed my_strlen() to utf8_width()Max Kellermann2008-10-026-16/+17
| | | | | | my_strlen() is a bad name for the function, since the return value is not a length, but a visible width on the screen. Rename it to utf8_width() and change its return type to "unsigned".
* moved code to charset.cMax Kellermann2008-10-0217-117/+169
| | | | | Move everything which deals with UTF-8 strings and character set conversion to charset.c, header charset.h.
* moved macros from ncmpc.h to main.c and screen.cMax Kellermann2008-10-023-20/+13
| | | | | Moved constants which are only used in one source file. Remove several unused macros.
* removed LIST_FORMAT, STATUS_FORMATMax Kellermann2008-10-025-14/+8
| | | | | Use options.list_format and options.status_format directly instead of these two macros.
* moved i18n macros to i18n.hMax Kellermann2008-10-0218-29/+56
| | | | | Don't make everybody include ncmpc.h just to have generic features. Move generic i18n macros to a separate header.
* options: use stdboolMax Kellermann2008-10-023-32/+30
| | | | | Use the standard "bool" type instead of glib's "gboolean". This way, options.h doesn't have to include the fat glib.h.
* removed the deprecated easy_download libraryMax Kellermann2008-10-022-121/+0
| | | | This library isn't being used anymore, delete it.
* moved default value macros to defaults.hMax Kellermann2008-10-025-16/+42
| | | | | These macros are only used by options.c and conf.c. Move them to a common internal header.
* options: initialize options.list_formatMax Kellermann2008-10-022-5/+5
| | | | | | Instead of checking whether options.list_format is set in the LIST_FORMAT macro, initialize it once with options.list_format. Same for options.status_format / STATUS_FORMAT.
* removed the debugging function D()Max Kellermann2008-10-0213-82/+1
| | | | gdb is for debugging. We don't need D() calls littered all over.
* screen_browser: unexport command implementationsMax Kellermann2008-10-022-23/+7
| | | | | | When we created created browser_cmd(), several functions of the screen_browser API weren't used by other sources anymore. We can now unexport them.
* screen_lyrics: add screen_lyrics_switch()Max Kellermann2008-10-024-2/+51
| | | | | | screen_lyrics_switch() opens the lyrics screen and displays the lyrics of the specified song. This way, the user may view the lyrics of any song in the database browser.
* screen: export function screen_switch()Max Kellermann2008-10-022-10/+13
| | | | | Provide an API for switching the currently displayed screen. Rename switch_screen_mode() to screen_switch().
* screen: no typedefs for methodsMax Kellermann2008-10-021-20/+9
| | | | | Since the method types are used only once, we do not need typedefs for that. Declare the method types within struct screen_functions.
* screen_browser: added browser_cmd()Max Kellermann2008-10-025-111/+76
| | | | Merge a lot of code from the 3 browser screen into browser_cmd().
* screen_artist: call artist_lw_cmd() at the end of artist_cmd()Max Kellermann2008-10-021-5/+5
| | | | | By calling artist_lw_cmd() after the big switch, we can override behaviour, and we can modify the command.
* screen_artist: don't call wrefresh() twiceMax Kellermann2008-10-021-1/+0
| | | | | artist_repaint() calls wrefresh(), don't call it again after that.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 14:32:18 +0000