aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* decoder/flac: fixed CUE seeking range checkMax Kellermann2009-11-112-14/+9
| | | | | | If flac_container_decode() gets a seek destination which is out of range, it ignores the SEEK command (never finishes it). This leads to MPD lockup, because the player thread waits for completion.
* oggflac: rewind stream after FLAC detectionMax Kellermann2009-11-112-0/+9
| | | | | The oggflac plugin has been completely broken for quite a while and nobody has noticed - maybe we should remove it?
* zzip: require libzzip 0.13Max Kellermann2009-11-102-1/+3
| | | | We need the function zzip_file_stat().
* input/mms: require libmms 0.4Max Kellermann2009-11-102-1/+2
| | | | We're using API functions which are not available in 0.3.
* sticker: added fallback for sqlite3_prepare_v2()Max Kellermann2009-11-102-0/+5
| | | | This function was not present in SQLite < 3.4.
* input/lastfm: fixed variable name in GLib<2.16 code pathMax Kellermann2009-11-102-1/+3
| | | | Should be "lastfm_user", not "lastfm_username".
* song_save: increased maximum line length to 32 kBMax Kellermann2009-11-012-3/+8
| | | | | | | The line buffer had a fixed size of 5 kB, and was allocated on the stack. This was too small for some users. As a hotfix, we're increasing the buffer size to 32 kB now, allocated on the heap. In MPD 0.16, we'll switch to dynamic allocation.
* decoder_control: removed unused DECODE_TYPE macrosMax Kellermann2009-10-311-3/+0
|
* decoder/ffmpeg: convert metadataMax Kellermann2009-10-282-4/+6
| | | | | | Convert the metadata with the libavformat function av_metadata_conv(). This ensures that canonical tag names are provided by libavformat, and we can remove the "artist" vs "author" workaround.
* update: delete ignored symlinks from databaseMax Kellermann2009-10-272-1/+6
| | | | | | When you disable the "follow_outside_symlinks" or the "follow_inside_symlinks" setting, the next update should remove the now-ignored files from the database.
* output_thread: check again if output is open on PAUSEMax Kellermann2009-10-212-0/+10
| | | | | Basically the same as the 0.15.5 patch "check again if output is open on CANCEL". Same race condition, same fix.
* Modify version string to post-release version 0.15.6~gitAvuton Olrich2009-10-182-1/+4
|
* mpd version 0.15.5release-0.15.5Avuton Olrich2009-10-182-2/+2
|
* decoder/flac: fixed two memory leaks in the CUE tag loaderMax Kellermann2009-10-162-2/+5
| | | | | | Don't initialize "vc" and "cs" with FLAC__metadata_object_new(); that value is overwritten by FLAC__metadata_get_tags() and FLAC__metadata_get_cuesheet().
* update: fixed memory leak during container scanMax Kellermann2009-10-162-3/+7
| | | | The return value of map_directory_child_fs() must be freed.
* update: song_file_new() cannot failMax Kellermann2009-10-161-3/+0
| | | | | Removed the NULL check. If that NULL check was correct, that would have been a memory leak (vtrack).
* output_thread: check again if output is open on CANCELMax Kellermann2009-10-162-1/+3
| | | | | | | | When the player thread unpauses, it sends CANCEL to the output thread, after having checked that the output is still open. Problem is when the output thread closes the device before it can process the CANCEL command - race condition. This patch adds another "open" check inside the output thread.
* input/curl: fixed endless loop during bufferingMax Kellermann2009-10-132-1/+2
| | | | | | | When the connection is lost while buffering, the CURL input plugin may enter an endless loop, because it does not check the EOF condition. This patch makes fill_buffer() return success only if there's at least one buffer, which is enough of a check.x
* riff, aiff: fixed "limited range" gcc warningMax Kellermann2009-10-113-10/+12
| | | | | | On 32 bit systems with large file support enabled (i.e. "sizeof(off_t) > sizeof(size_t)") gcc emits a warning because a size_t cast to off_t can never become negative.
* decoder_thread: change the fallback decoder name to "mad"Max Kellermann2009-10-112-1/+2
| | | | | | When there is no Content-Type response header, try the "mad" decoder plugin. It uesd to be named "mp3", and we forgot to change the fallback name in decoder_thread.c.
* input/curl: don't abort if a packet has only metadataMax Kellermann2009-10-112-20/+24
| | | | | | | | | When a received chunk of data has only icy-metadata, there was no usable data left for input_curl_read() to return, and thus it returned 0 bytes. "0" however is a special value for "end of file" or "error". This patch makes input_curl_read() read more data from the socket, until the read request can be fulfilled (or until there's really EOF).
* input/curl: moved code to fill_buffer()Max Kellermann2009-10-111-27/+40
|
* Modify version string to post-release version 0.15.5~gitAvuton Olrich2009-10-032-1/+4
|
* mpd version 0.15.4release-0.15.4Avuton Olrich2009-10-032-2/+2
|
* decoder/ffmpeg: use the "artist" tag if "author" is not presentMax Kellermann2009-09-302-2/+6
| | | | | | | Usually, we read our "artist" tag from ffmpeg's "author" tag. In some cases however (e.g. APE), this tag is named "artist". This patch implements a fallback: if no "author" is found, MPD tries to use "artist".
* decoder/faad: skip assertion failure on large ID3 tagsMax Kellermann2009-09-302-2/+7
| | | | | | When the ID3 tag in an AAC file is larger than the current buffer, the function decoder_buffer_consume() aborts. By using the new function decoder_buffer_skip() instead, we can safely skip the ID3 tag.
* decoder_buffer: added function decoder_buffer_skip()Max Kellermann2009-09-302-0/+36
|
* input/mms: fix G_LOG_DOMAIN valueSerge Ziryukin2009-09-201-1/+1
|
* output/osx: fix the OS X 10.6 buildPatrik Weiskircher2009-09-202-0/+3
| | | | Include CoreServices/CoreServices.h.
* doc/protocol: clarify "update"Max Kellermann2009-09-101-13/+8
| | | | | The update job id is positive. When used in a command list, MPD prints one job id for each "update" command.
* doc/mpdconf.example: additional comment signs for some parametersMax Kellermann2009-09-101-18/+18
| | | | | Add a second column of comment signs on some parameters which users shouldn't usually set, unless they know what they're doing.
* decoder/vorbis: revert "faster tag scanning with ov_test_callback()"Max Kellermann2009-09-102-1/+3
| | | | | This patch made ov_time_total() unusable, and MPD did not know the duration of songs.
* Modify version string to post-release version 0.15.4~gitAvuton Olrich2009-08-292-1/+4
|
* mpd version 0.15.3release-0.15.3Avuton Olrich2009-08-292-2/+2
|
* Document nextsong and nextsongid.Anton Khirnov2009-08-241-0/+18
|
* decoder/vorbis: faster tag scanning with ov_test_callback()Rasmus Steinke2009-08-242-1/+3
| | | | | | | | | using ov_test_callback with function CALLBACKS_STREAMONLY will cause scanning to stop after the comment field. ov_open (and ov_test) default to CALLBACKS_DEFAULT which scans the file structure causing a huge slowdown. The speed improvement is huge: It scanned my files around 10x faster This procedure has been recommended by monthy (main vorbis developer) and was said to be safe for scanning files.
* update: don't re-read unchanged container filesIgor Kuzmin2009-08-192-1/+3
| | | | | | | MPD checks if every flac (possibly other types as well) file contains cuesheet on every update, which produces unneeded I/O. My music collection is on NFS share, so it's quite noticeable. IMHO, it shouldn't re-read unchanged files, so I wrote simple patch to fix it.
* output_init: initialize the "pause" flagMax Kellermann2009-08-182-0/+3
| | | | Fix stuttering due to uninitialized variable.
* Modify version string to post-release version 0.15.3~gitAvuton Olrich2009-08-152-1/+4
|
* mpd version 0.15.2release-0.15.2Avuton Olrich2009-08-152-2/+2
|
* output/shout: minimize the unpause latencyMax Kellermann2009-08-142-0/+8
| | | | | During the pause loop, manually sleep for 500ms if shout_delay() returns a value greater than that. Don't exhaust libshout's buffer.
* output: fixed shout stuck pause bugMax Kellermann2009-08-144-0/+22
| | | | | | Explicitly make the output thread leave the ao_pause() loop. This patch is a workaround, and the "pause" flag is not managed in a thread-safe way, but that's good enough for now.
* directory: free empty directories after removing them (memleak)Max Kellermann2009-08-142-3/+9
| | | | | dirvec_delete() does not free the object, we have to call directory_free() afterwards.
* update: free temporary string in container scan (memleak)Max Kellermann2009-08-142-2/+7
| | | | The return value of map_directory_child_fs() must be freed.
* decoder/flac: don't allocate cuesheet twice (memleak)Max Kellermann2009-08-142-4/+7
| | | | | | | The function flac_cue_track() first calls FLAC__metadata_object_new(), then overwrites this pointer with FLAC__metadata_get_cuesheet(). This allocate two FLAC__StreamMetadata objects, but the first pointer is lost, and never freed.
* update: free empty path string (memleak)Max Kellermann2009-08-142-1/+3
| | | | | When you pass an empty string to directory_update_init(), it was not freed by update_task().
* decoder/flac: fixed indentation of flac_comment_value()Max Kellermann2009-07-221-19/+21
|
* decoder/flac: parse all replaygain tagsMax Kellermann2009-07-222-14/+19
| | | | | The FLAC replaygain parser used the "||" operator. This made the code stop after the first value which was found.
* decoder/flac: return early from flac_find_float_comment()Max Kellermann2009-07-221-21/+22
| | | | | When one metadata check fails, return quickly. This removes 2 levels of indent.
* decoder/flac: removed misplaced authorship commentMax Kellermann2009-07-221-1/+0
| | | | This belongs into "git annotate" or AUTHORS.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 07:55:12 +0000