aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* added string set libraryMax Kellermann2008-09-083-0/+195
| | | | | | | | "struct strset" is a hashed string set: you can add strings to this library, and it stores them as a set of unique strings. You can get the size of the set, and you can enumerate through all values. This will be used to replace the linear tagTracker library.
* output: const plugin structuresMax Kellermann2008-09-0811-11/+11
| | | | | Since the plugin struct is never modified, we should store it in constant locations.
* output: static audio_output_plugin list as arrayMax Kellermann2008-09-088-80/+104
| | | | | | Instead of having to register each output plugin, store them statically in an array. This eliminates the need for the List library here, and saves some small allocations during startup.
* output: replace audio_output.*Func with audio_output.pluginMax Kellermann2008-09-072-24/+12
| | | | | Instead of copying all that stuff from the audio output plugin to the audio output structure, store a pointer to the plugin.
* output: renamed typedef AudioOutput to struct audio_outputMax Kellermann2008-09-0714-131/+142
| | | | | Also rename AudioOutputPlugin to struct audio_output_plugin, and use forward declarations to reduce include dependencies.
* output: added output_api.hMax Kellermann2008-09-0715-90/+115
| | | | | Just like decoder_api.h, output_api.h provides the audio output API which is used by the plugins.
* pack the struct audio_formatMax Kellermann2008-09-071-1/+1
| | | | | | Due to clumsy layout, the audio_format struct took 12 bytes. Move the "channels" to the end, so it can be merged into the same 32 bit slot as "bits", which reduces the struct size to 8 bytes.
* audio_format: converted typedef AudioFormat to struct audio_formatMax Kellermann2008-09-0734-83/+98
| | | | | Get rid of CamelCase, and don't use a typedef, so we can forward-declare it, and unclutter the include dependencies.
* playlist: return -1 after assert(0)Max Kellermann2008-09-071-0/+1
| | | | | | | print_playlist_result() had an assert(0) at the end, in case there was an invalid result value. With NDEBUG, this resulted in a function not returning a value - add a dummy "return -1" at the end to keep gcc quiet.
* playlist: replaced song_id_exists() with song_id_to_position()Max Kellermann2008-09-071-16/+29
| | | | | | | Since all callers of song_id_exists() will map it to a song position after the check, introduce a new function called song_id_to_position() which performs both the check and the map lookup, including nice assertions.
* command: use client_[gs]et_permission()Max Kellermann2008-09-073-84/+86
| | | | | | Don't pass a pointer to client->permission to processCommand(), better let the code in command.c use the new permission getter/setter functions.
* client: added client_[gs]et_permission()Max Kellermann2008-09-072-0/+14
| | | | | The code in command.c shouldn't mess with a pointer to client->permission. Provide an API for accessing this value.
* command: don't pass permission as pointer where appropriateMax Kellermann2008-09-071-6/+6
| | | | | Some functions don't want to modify a client's permission set. Pass the permissions to them by value, not by reference.
* audio_format: volatile removalEric Wong2008-09-071-3/+3
| | | | | | | | | | | | | | | | | volatile provides absolutely no guarantee thread-safety in SMP environments. volatile was designed to access memory locations in peripheral hardware directly; not for SMP. If volatile is needed to work properly on SMP, then it is only hiding subtle bugs. volatile only prevents the /compiler/ from making optimizations when accessing variables. CPUs do their own optimizations at runtime so it cannot guarantee registers of CPUs are flushed to memory cache-coherent access on different CPUs. Furthermore, the thread-communication via condition variables between threads sharing audio formats already results in memory barriers.
* tag: oops, of course items is now ** and not *Eric Wong2008-09-071-2/+2
| | | | | | Gah, it seems like doing sizeof here either way is error prone. Too easy to leave out a '*' character we can forget.
* tag: lock all accesses to tag_poolEric Wong2008-09-073-6/+15
| | | | | | | | | | The tag pool is a shared global resource that is infrequently modified. However, it can occasionally be modified by several threads, especially by the metadata_pipe for streaming metadata (both reading/writing). The bulk tag_item pool is NOT locked as currently only the update thread uses it.
* tag: introduce handy items_size() functionEric Wong2008-09-071-11/+12
| | | | | | | | | | | Trying to read or remember "tag->numOfItems * sizeof(*tag->items)" requires too much thinking and mental effort on my part. Also, favor "sizeof(struct mpd_tag)" over "sizeof(*tag->items)" because the former is easier to read and follow, even though the latter is easier to modify if the items member changes to a different type.
* fix -Wcast-qual -Wwrite-strings warningsMax Kellermann2008-09-076-33/+43
| | | | | | | | | The previous patch enabled these warnings. In Eric's branch, they were worked around with a generic deconst_ptr() function. There are several places where we can add "const" to pointers, and in others, libraries want non-const strings. In the latter, convert string literals to "static char[]" variables - this takes the same space, and seems safer than deconsting a string literal.
* build: enable -Wcast-qual -Wwrite-strings CFLAGSEric Wong2008-09-072-1/+4
| | | | | We're pretty careful about using const these days, so enable these warnings to keep us that way.
* removed fdprintf() and client_print()Max Kellermann2008-09-075-120/+0
| | | | | | All callers of fdprintf() have been converted to client_printf() or fprintf(); it is time to remove this clumsy hack now. We can also remove client_print() which took a file descriptor as parameter.
* client: removed client_get_fd()Max Kellermann2008-09-072-15/+0
| | | | | | Now that we have removed all invocations of client_get_fd(), we can safely remove this transitional function. All access to the file descriptor is now hidden behind the interface declared in client.h.
* audio: don't pass "fd" to printAudioDevices()Max Kellermann2008-09-073-9/+12
| | | | Pass the client struct instead.
* stats: don't pass "fd" to printStats()Max Kellermann2008-09-073-12/+21
| | | | Pass the client struct instead of the raw file descriptor.
* playlist: don't pass "fd" to showPlaylist(), playlistChangesPosId()Max Kellermann2008-09-073-11/+10
| | | | Pass the client struct instead of the raw file descriptor.
* playlist: added playlist_save()Max Kellermann2008-09-071-2/+11
| | | | | | The shared code in showPlaylist() isn't worth it, because we aim to remove fdprintf(). Duplicate this small function, and enable stdio buffering for saved playlists.
* ls: don't pass "fd" to lsPlaylists(), printRemoteUrlHandlers()Max Kellermann2008-09-073-10/+12
| | | | Pass the client struct instead of the raw file descriptor.
* tag: don't pass "fd" to printVisitedInTagTracker()Max Kellermann2008-09-073-8/+9
| | | | Pass the client struct instead of the raw file descriptor.
* command: concatenate strings at compile timeMax Kellermann2008-09-071-27/+27
| | | | | | String literals (including those defined in CPP macros) can be concatenated at compile time. This saves some CPU cycles in vsnprintf() at run time.
* command: removed commandError()Max Kellermann2008-09-072-27/+0
| | | | | commandError() has been superseded by command_error(), and is not being used anymore. Remove it.
* playlist: pass struct client to loadPlaylist()Max Kellermann2008-09-073-5/+5
| | | | | | | The function loadPlaylist() wants to report incremental errors to the client, for this reason we cannot remove its protocol dependency right now. Instead, make it use the client struct instead of the raw file descriptor.
* pass "struct client" to dbUtils.c, song.c, tag_print.cMax Kellermann2008-09-0712-110/+121
| | | | | | Don't pass the raw file descriptor around. This migration patch is rather large, because all of the sources have inter dependencies - we have to change all of them at the same time.
* command: pass struct client to all commandsMax Kellermann2008-09-071-248/+259
| | | | | | | Pass the client struct to CommandHandlerFunction and CommandListHandlerFunction. Most commands cannot take real advantage of that yet, since most of them still work with the raw file descriptor.
* command: pass struct client to getCommandEntryAnd...()Max Kellermann2008-09-071-26/+21
| | | | | Instead of passing the file descriptor, pass the client struct to getCommandEntryAndCheckArgcAndPermission().
* command: added command_success() and command_error()Max Kellermann2008-09-073-5/+35
| | | | | | | These two functions take a client struct instead of the file descriptor. We will now begin passing the client struct around instead of a raw file descriptor (which needed a linear lookup in the client list to be useful).
* audio: don't pass "fd" to {en,dis}ableAudioDevice()Max Kellermann2008-09-073-18/+21
| | | | No protocol code in the audio output library.
* volume: don't pass "fd" to changeVolumeLevel()Max Kellermann2008-09-073-22/+26
| | | | | The "volume" library shouldn't talk to the client. Move error handling to command.c.
* directory: don't pass "fd" to updateInit()Max Kellermann2008-09-073-17/+53
| | | | Again, move error handling to command.c.
* directory: printDirectoryInfo() does not call commandError()Max Kellermann2008-09-072-4/+4
| | | | Move another ocurrence of error handling over to command.c.
* directory: don't pass fd to traverseAllIn()Max Kellermann2008-09-076-32/+69
| | | | | | | | This patch continues the work of the previous patch: don't pass a file descriptor at all to traverseAllIn(). Since this fd was only used to report "directory not found" errors, we can easily move that check to the caller. This is a great relief, since it removes the dependency on a client connection from a lot of enumeration functions.
* directory: don't pass fd to traverseAllIn() callbacksMax Kellermann2008-09-074-51/+81
| | | | | | | | | | Database traversal should be generic, and not bound to a client connection. This is the first step: no file descriptor for the callback functions forEachSong() and forEachDir(). If a callback needs the file descriptor, it has to be passed in the void*data pointer somehow; some callbacks might need a new struct for passing more than one parameter. This might look a bit cumbersome right now, but our goal is to have a clean API.
* playlist: PlaylistInfo() does not call commandError()Max Kellermann2008-09-072-6/+15
| | | | | | Continuing the effort of removing protocol specific calls from the core libraries: let the command.c code call commandError() based on PlaylistInfo's return value.
* playlist: don't pass "fd" to storedPlaylist.c functionsMax Kellermann2008-09-076-150/+124
| | | | | Return an "enum playlist_result" value instead of calling commandError() in storedPlaylist.c.
* playlist: don't pass "fd" to playlist.c functionsMax Kellermann2008-09-074-188/+247
| | | | | | The playlist library shouldn't talk to the client if possible. Introduce the "enum playlist_result" type which the caller (i.e. command.c) may use to generate an error message.
* playlist: showPlaylist() and shufflePlaylist() cannot failMax Kellermann2008-09-073-10/+8
| | | | Make them both return void.
* playlist: moved "repeat" and "random" value checks to command.cMax Kellermann2008-09-073-24/+26
| | | | | | | | Client's input values should be validated by the command implementation, and the core libraries shouldn't talk to the client directly if possible. Thus, setPlaylistRepeatStatus() and setPlaylistRandomStatus() don't get the file descriptor, and cannot fail (return void).
* playlist: fix FILE* leak in appendSongToStoredPlaylistByPath()Max Kellermann2008-09-071-0/+2
| | | | | When an error occurs after the file has been opened, the function will never close the FILE object.
* playlist: replaced run-time check with assertionMax Kellermann2008-09-071-2/+1
| | | | | | The "fspath" argument of writeStoredPlaylistToPath() must never be NULL. There should be an assertion on that, instead of a run-time check.
* playlist: added is_valid_playlist_name()Max Kellermann2008-09-072-3/+10
| | | | | | | | The function valid_playlist_name() checks the name, but it insists on reporting an eventual error to the client. The new function is_valid_playlist_name() is more generic: it just returns a boolean, and does not care what the caller will use it for. The old function valid_playlist_name() will be removed later.
* tag: added buffered versions of the tag_print.c codeMax Kellermann2008-09-074-3/+85
| | | | | | | | | | | Currently, when the tag cache is being serialized to hard disk, the stdio buffer is flushed before every song, because tag_print.c performs unbuffered writes on the raw file descriptor. Unfortunately, the fdprintf() API allows buffered I/O only for a client connection by looking up the client pointer owning the file descriptor - for stdio, this is not possible. To re-enable proper stdio buffering, we have to duplicate the tag_print.c code without fprintf() instead of our custom fdprintf() hack. Add this duplicated code to tag_save.c.
* song: moved code to song_print.c, song_save.cMax Kellermann2008-09-0710-183/+284
| | | | | | | Move everything which dumps song information (via tag_print.c) to a separate source file. song_print.c gets code which writes song data to the client; song_save.c is responsible for serializing songs from the tag cache.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-15 06:39:22 +0000