aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* directory: make it clear that DIRECTORY_MTIME is deprecatedEric Wong2008-09-281-1/+1
| | | | A long time ago in an mpd far away...
* directory: remove "Mp3" referencesEric Wong2008-09-283-22/+22
| | | | | MPD has supported more audio formats than just MP3 for over five years...
* playlist: deleteASongFromPlaylist takes a const Song *Eric Wong2008-09-282-2/+2
| | | | We don't change the song pointer there, either.
* songvec: songvec_delete takes a const Song pointerEric Wong2008-09-282-2/+2
| | | | We don't modify the Song when we delete it
* directory: remove shortname arguments everywhereEric Wong2008-09-281-79/+40
| | | | | | It was a huge confusing mess of parameter passing around and around. Add a few extra assertions to ensure we're handling parent/child relationships properly.
* path: add mpd_basename() functionEric Wong2008-09-282-0/+20
| | | | | | | This is like basename(3) but with predictable semantics independent of C library or build options used. This is also much more strict and does not account for trailing slashes (mpd should never deal with trailing slashes on internal functions).
* directory.h: remove directory_sigChldHandler declEric Wong2008-09-281-2/+0
| | | | | We no longer fork for directory updates, so we no longer have children to reap.
* directory: replace DirectoryList with dirvecEric Wong2008-09-284-197/+175
| | | | | Small memory reduction compared to songvec since most users have much fewer dirs than songs, but still nice to have.
* directory: remove unused CPP definesEric Wong2008-09-281-4/+0
| | | | We no longer for for updates
* songvec_free => songvec_destroyEric Wong2008-09-283-3/+3
| | | | | "free" implies the songvec structure itself is freed, which is not the case.
* directory.c: kill unnecessary includesEric Wong2008-09-281-4/+0
|
* directory: update playlist version if updatedEric Wong2008-09-281-1/+6
| | | | | | | | | | | | If we updated the mpd metadata database; then there's a chance some of those songs in the playlist will have updated metadata. So be on the safe side and increment the playlist version number if _any_ song changed (this is how all released versions of mpd did it, too). This bug was introduced recently when making "update" threaded. Thanks to stonecrest for the bug report.
* playlist: fix currentsong info after swapping songsEric Wong2008-09-281-0/+4
| | | | | | | | | | We forgot to update the playlist.queued marker if playlist.current changed. Additionally, if the queue cleared in any other mode, attempt to requeue (as it's a harmless no-op otherwise). Thanks to stonecrest for the bug report.
* playlist: reset after we've hit the endEric Wong2008-09-281-0/+6
| | | | | If repeat is off, we reset (and reshuffle in random mode) the playlist.
* advance to the next song on decoder errorsEric Wong2008-09-283-6/+17
| | | | | | Fix this regression introduced in the core rewrite so that we now skip to the next song when we encounter an error with the song we tried to decode.
* COMMANDS: assorted formatting fixesEric Wong2008-09-271-21/+22
| | | | | | * spaces => tabs * long lines wrapped * trailing whitespace killed
* COMMANDS: document moveid with negative _to_ argument, tooEric Wong2008-09-271-1/+3
|
* COMMANDS: document addid with optional position argumentEric Wong2008-09-271-1/+4
|
* song: removed type SongListMax Kellermann2008-09-264-45/+2
| | | | SongList has been superseded by struct songvec.
* doc/COMMANDS: document "addid"Max Kellermann2008-09-261-0/+8
|
* command: fix command "addid"Max Kellermann2008-09-261-1/+1
| | | | | | With patch 8d2830b3, I broke "addid": it did not return the id of the new song, because of a typo in the return condition (== instead of !=).
* properly configure the M4 macro directoryMax Kellermann2008-09-262-0/+2
| | | | | Add information about the M4 macro dir ./m4/ to both configure.ac and Makefile.am.
* Revert "directory: serialize freeSong() within the main thread"Eric Wong2008-09-231-9/+1
| | | | | | | | This reverts commit efefaee1f9535012be2fbfea8f0f870904daad5d. Conflicts: src/directory.c
* songvec: avoid free(NULL)Eric Wong2008-09-231-2/+4
| | | | Potentially broken free() implementations don't like it
* directory: use songvec_free to prevent memory leaks.Eric Wong2008-09-231-2/+1
|
* directory: fix leak introduced with threaded updateEric Wong2008-09-231-1/+1
| | | | | Use freeList() instead of free() to free all elements in the list.
* directory: serialize freeSong() within the main threadEric Wong2008-09-231-1/+10
| | | | | | | | | | | | | | | | | | It's possible the playlist will be accessing a song that is to be freed in the update thread. Rather than going through the complexity (and potential to make mistakes) of locking the playlist (as well as losing CPU cycles/pipelining due to barriers with mutexes), we'll just line up all songs to be freed in the main thread. It's relatively uncommon to call freeSong() heavily (as it is to update); so the extra, temporary memory usage won't be very noticeable. Additionally, if a song is renamed and it contains unique tag item; this has the additional side effect of preventing unnecessary fragmentation where an item is freed and shortly reallocated.
* log: remove umask() calls, just change open(2) argsEric Wong2008-09-221-8/+2
| | | | The umask calls were remants of when we used fopen().
* Remove EINTR checking for open(2)Eric Wong2008-09-222-4/+2
| | | | open(2) should only interrupt on "slow" devices, afaik...
* directory: don't leak file handles if we get a corrupt dbEric Wong2008-09-221-1/+1
|
* Merge branch 'ew/directory'Eric Wong2008-09-228-221/+102
|\ | | | | | | | | | | | | * ew/directory: songvec: remove songvec_prune directory: update do its work inside a thread directory: use enum update_return for return values
| * songvec: remove songvec_pruneEric Wong2008-09-223-27/+0
| | | | | | | | | | | | Any pruned files will be noticed during update and pruned from the live database, so this inefficient function can go away and never come back.
| * directory: update do its work inside a threadEric Wong2008-09-225-125/+56
| | | | | | | | | | | | | | | | | | A lot of the preparation was needed (and done in previous months) in making update thread-safe, but here it is. This was the first thing I made work inside a thread when I started mpd-uclinux many years ago, and also the last thing I've done in mainline mpd to work inside a thread, go figure.
| * directory: use enum update_return for return valuesEric Wong2008-09-221-72/+49
| | | | | | | | This way we avoid having to document -1, 0, 1
* | Merge branch 'ew/directory'Eric Wong2008-09-2016-253/+318
|\| | | | | | | | | | | | | | | | | | | * ew/directory: Don't try to prune unless we're updating workaround race condition on updates with broken signal blocking Replace SongList with struct songvec directory: remove unused updateMp3Directory() function start using prefixcmp() Add prefixcmp() (stol^H^H^H^Hborrowed from git)
| * Don't try to prune unless we're updatingEric Wong2008-09-201-1/+2
| | | | | | | | | | | | Pruning is very expensive and we won't need it in the future anyways. This brings startup back to previous speeds (before songvec changes).
| * workaround race condition on updates with broken signal blockingEric Wong2008-09-201-39/+50
| | | | | | | | | | | | | | | | | | pthreads with our existing signal blocking/handling is broken, for now just sleep a bit in the child to prevent the CHLD handler from being called too early. Also, improve error reporting when handling SIGCHLD by storing the status to be called in the main task (which can be logged, since we can't do logging inside the sig handler).
| * Replace SongList with struct songvecEric Wong2008-09-208-136/+226
| | | | | | | | | | | | | | Our linked-list implementation is wasteful and the SongList isn't modified enough to benefit from being a linked list. So use a more compact array of song pointers which saves ~200K on a library with ~9K songs (on x86-32).
| * directory: remove unused updateMp3Directory() functionEric Wong2008-09-202-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | It hasn't been used in many years commit 3a89afdd80f228139554372a83a9d74486acf691 Author: Warren Dukes <warren.dukes@gmail.com> Date: Sat Nov 20 20:28:32 2004 +0000 remove --update-db option (SVN r2719)
| * start using prefixcmp()Eric Wong2008-09-208-58/+29
| | | | | | | | | | LOC reduction and less noise makes things easier for tired old folks to follow.
| * Add prefixcmp() (stol^H^H^H^Hborrowed from git)Eric Wong2008-09-202-0/+12
| | | | | | | | | | | | | | This allows us to avoid the nasty repetition in strncmp(foo, bar, strlen(foo)). We'll miss out on the compiler optimizing strlen() into sizeof() - 1 for string literals for this; but we don't use this it for performance-critical functions anyways...
* | Oops, open() with O_CREAT is nicer with a modeEric Wong2008-09-202-2/+2
| | | | | | | | Respect the user's umask (and the number of the beast!)
* | volume: oops, only #include <alloca.h> if OSS is enabledEric Wong2008-09-181-1/+0
| |
* | oss: avoid heap allocations when configuring mixerEric Wong2008-09-181-13/+13
|/ | | | Noticed-by: Courtney Cavin
* Move away from fprintf() when writing DB/state_fileEric Wong2008-09-1810-55/+60
| | | | | | | | | I have serious trust issues when using stdio to write to the FS. So it's best to clean this code out so I can start figuring out what's wrong with Rasi's box not updating... None of these writes take place in a performance-critical setting anyways...
* fdprintf and vfdprintf get error handlingEric Wong2008-09-182-14/+22
|
* Directory: don't allocate stat information dynamicallyEric Wong2008-09-182-50/+22
| | | | | | | This should save a few thousand ops. Not worth it to malloc for such a small (3-words on 32-bit ARM and x86) structures. Signed-off-by: Eric Wong <normalperson@yhbt.net>
* mp3: fix long line, I can't read past 80 colsEric Wong2008-09-171-1/+2
|
* mp3: fix buffer overflow when max_frames is too largeMax Kellermann2008-09-171-0/+5
| | | | | | | The function decodeFirstFrame() allocates memory based on data from the mp3 header. This can make the buffer size allocation overflow, or lead to a DoS attack with a very large buffer. Cap this buffer at 8 million frames, which should really be enough for reasonable files.
* client: check expired after client_process_line()Max Kellermann2008-09-171-1/+2
| | | | | | The assertion on "!client_is_expired(client)" was wrong, because writing the command response may cause the client to become expired. Replace that assertion with a check.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-29 10:46:06 +0000