aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* lyrics: added callbackMax Kellermann2008-09-233-69/+56
| | | | | Instead of letting our caller poll lyrics_result(), call it back as soon as we have the result.
* lyrics: reimplemented with aynchronous I/OMax Kellermann2008-09-231-69/+98
| | | | | Instead of creating a thread for handling lyrics plugin data, register a channel at the glib main loop.
* screen_lyrics: set current.songMax Kellermann2008-09-231-2/+2
| | | | | | The variable current.song was never set, thus the cache did not work. Don't reset it in screen_lyrics_clear() (which is called from screen_lyrics_set()).
* autogen.sh: don't ignore errorsMax Kellermann2008-09-221-1/+1
| | | | Set the shell option "-e" to abort when one of the tools fails.
* options: added constant option_table_sizeMax Kellermann2008-09-221-7/+7
| | | | | Instead of checking for the sentinel at the end of the option table, check the option_table_size constant.
* options: constant options_tableMax Kellermann2008-09-221-3/+3
| | | | Make the options_table constant, since it is never modified.
* screen_utils: simplified call to wreadln_masked()Max Kellermann2008-09-221-3/+2
| | | | | | If prompt is NULL, do not add a second call to wreadln_masked() with a literal string, but assign this literal string to the variable "prompt". This saves several bytes in the compiled binary.
* screen_utils: hide cursor after screen_read_password()Max Kellermann2008-09-221-2/+5
| | | | | The call to curs_set(0) in screen_read_password() was dead code, because it was after the function return. Repair that.
* screen: unsigned integers for screen dimensionsMax Kellermann2008-09-222-5/+5
| | | | Store screen width and height as unsigned integer.
* code style, indent with tabs IXMax Kellermann2008-09-222-309/+301
| | | | Follow the same code style als MPD itself.
* screen: simplified CMD_SCREEN_UPDATE handlersMax Kellermann2008-09-223-8/+4
| | | | | Since screen.c has default code for CMD_SCREEN_UPDATE, return 0 from the command handlers and let screen.c do the rest.
* screen: don't set list_window->repaintMax Kellermann2008-09-223-9/+1
| | | | | | Several screens ignore the attribute list_window->repaint. Don't set it there. It will be replaced with a more intelligent repaint algorithm later.
* screen: removed window.cur_action_idMax Kellermann2008-09-221-1/+0
| | | | The variable cur_action_id is not used at all.
* screen: last_cmd should be a command_tMax Kellermann2008-09-221-1/+2
| | | | | last_cmd stores the previous command sent to the screen. It is not a timestamp, and its type should be command_t.
* screen: moved input_timestamp to screen_play.cMax Kellermann2008-09-223-4/+6
| | | | Since the input_timestamp is only used by screen_play, move it there.
* screen: moved list_window mouse code to list_window.cMax Kellermann2008-09-226-28/+47
| | | | | | Move the portion of screen_get_mouse_event() which handles list_window clicks to list_window.c. The code contained a NULL pointer dereference, which is now fixed.
* screen: moved code to ncu.cMax Kellermann2008-09-226-35/+97
| | | | | Moved basic libncurses initialization to ncu.c and ncu.h. Keep generic code out of screen.c.
* main: free keyboard IO channelMax Kellermann2008-09-221-2/+7
| | | | Before terminating ncmpc, free the keyboard GIOChannel object.
* configure: modern AC_INIT and AM_INIT_AUTOMAKE invocationMax Kellermann2008-09-221-3/+2
| | | | | Provide program name and version in AC_INIT. Add the option "dist-bzip2" to AM_INIT_AUTOMAKE.
* added option "welcome-screen-list"David Shakaryan2008-09-224-1/+9
| | | | | "welcome-screen-list" shows the screen list in the top row shortly after startup, and is enabled by default.
* browse: ensure that filelist!=NULLMax Kellermann2008-09-212-4/+18
| | | | | There are several places where browser.filelist can become NULL. Catch that everywhere and generate an empty filelist in this case.
* browser: check if the selection is validMax Kellermann2008-09-212-1/+8
| | | | Don't call filelist_get() with an invalid index.
* support: added assertionsMax Kellermann2008-09-211-0/+16
| | | | Check the function parameters.
* screen_artist: check if anything is selectedMax Kellermann2008-09-211-0/+8
| | | | | Don't try to call add_query() with no valid selection, this causes a segfault. This usually happens when ncmpc isn't connected.
* libmpdclient: added another connection->sock checkMax Kellermann2008-09-211-0/+6
| | | | Check if connection->sock is valid in mpd_executeCommand().
* mpdclient: check errorCode only if MPD_ERROR_ACK is setMax Kellermann2008-09-211-1/+2
| | | | | | connection->errorCode has an undefined value when connection->error is not MPD_ERROR_ACK. Read it only if MPD_ERROR_ACK is set, to make valgrind happy.
* mpdclient: fix memory leak in mpdclient_finish_command()Max Kellermann2008-09-211-4/+5
| | | | | During authentication, the message pointer was allocated, but never freed. Allocate it only if it is really used (and freed).
* code style, indent with tabs VIIIMax Kellermann2008-09-211-171/+143
| | | | Follow the same code style als MPD itself.
* libmpdclient: check connection->sock >= 0Max Kellermann2008-09-211-0/+10
| | | | | mpd_wait() must not be called when the socket is dead; add an assertion there. In mpd_recv(), add a run-time check.
* added optional bitrate display to status barJ. Alexander Treuman2008-09-213-4/+20
| | | | | If visible-bitrate is enabled, then the current bitrate will be drawn next to the song time in the status bar. By default it will not be displayed.
* wreadln: adding additional line editing bindsJ. Alexander Treuman2008-09-211-1/+9
| | | | | Adding some GNU readline-style binds. These are ^B/^F to move the cursor back/forward, and ^N/^P to go to the next/previous line.
* ncmpc.1: -k is the short version of --key-file, not -PJ. Alexander Treuman2008-09-211-1/+1
|
* generate po/Makefile.in instead of bundling itJ. Alexander Treuman2008-09-212-255/+1
| | | | | | | The previously bundled po/Makefile.in would use predefined variables that should be set by the configure script. f.e., $prefix was defined as /usr/local, and caused po files to always be installed there instead of in the prefix given to ./configure.
* configure.ac: don't enable the lyrics screen by defaultJ. Alexander Treuman2008-09-211-1/+1
| | | | | The configure help text already said the lyrics screen was disabled by default. Now it actually will be.
* autogen: don't run ./configure if $NOCONFIGURE is setJ. Alexander Treuman2008-09-211-2/+4
|
* mpdclient: don't call screen_status_message()Max Kellermann2008-09-211-2/+0
| | | | The caller should decide how to display error messages.
* Adding crop feature in ncmpcYannick LM2008-09-216-0/+44
| | | | | The "crop" command deletes all songs from the playlist, except the one currently being played.
* screen_help: removed update() methodMax Kellermann2008-09-211-13/+6
| | | | | Why redraw the help screen when nothing has changed? Redraw it only after help_cmd(), and when explicitly requested (help_paint()).
* filelist: fix segfault during filelist_sort()Max Kellermann2008-09-191-1/+13
| | | | | | | When I converted the filelist from GList to GPtrArray, I missed that the GCompareFunc does not actually get the pointers from g_ptr_array_sort(), but pointers to the pointers... run g_ptr_array_sort_with_data() instead with a wrapper function.
* filelist: free entries with g_slice_free()Max Kellermann2008-09-191-2/+2
| | | | | Somehow I forgot about changing free() to g_slice_free() in the previous patch...
* filelist: allocate entries with g_slice_alloc()Max Kellermann2008-09-191-4/+2
| | | | | In this case, slices are faster. Also fix a memory leak in filelist_prepend() which I simply forgot about in the last patch set.
* properly configure M4 macro dirunK2008-09-192-0/+2
| | | | | Add information about the M4 macro dir ./m4/ to both configure.ac and Makefile.am.
* filelist: use GPtrArray instead of GListMax Kellermann2008-09-195-63/+57
| | | | | Since we do a lot of indexed accesses to the filelist, a linked list doesn't seem appropriate. Use GPtrArray instead.
* browser: added function browser_get_selected()Max Kellermann2008-09-191-9/+11
| | | | | browser_get_selected() checks if there is a file list and a valid selection, and returns the selected entry.
* screen_search: free second file listMax Kellermann2008-09-191-0/+1
| | | | Fix a memory leak: the concatened list was never freed.
* filelist: provide more functions for working with a filelistMax Kellermann2008-09-197-58/+124
| | | | Avoid direct accesses to the filelist struct, provide an API for that.
* filelist: drop "mpdclient" prefixMax Kellermann2008-09-198-18/+16
| | | | | The separate filelist library does not depend on mpdclient, so the prefix is superfluous.
* browser: use mpdclient_filelist_find_song() in set_highlight()Max Kellermann2008-09-191-18/+9
| | | | | A song should not be twice in the browser. Simplify set_highlight() by finding the entry with mpdclient_filelist_find_song().
* browser: song must not be NULL in set_highlight()Max Kellermann2008-09-191-2/+1
| | | | | The caller must not pass NULL to set_highlight(). Replaced check with assertion.
* filelist: song must not be NULLMax Kellermann2008-09-191-1/+4
| | | | | A caller must not pass NULL to mpdclient_filelist_find_song(). Replace the check with an assertion.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-28 04:29:12 +0000