3 files changed, 54 insertions, 49 deletions

diff --git a/src/db/plugins/upnp/Directory.cxx b/src/db/plugins/upnp/Directory.cxx
index e94a1a997..55f2693ae 100644
--- a/src/db/plugins/upnp/Directory.cxx
+++ b/src/db/plugins/upnp/Directory.cxx
@@ -89,18 +89,18 @@ ParseDuration(const char *duration)
  * this. Twonky returns directory names (titles) like 'Artist/Album'.
  */
 gcc_pure
-static std::string
-titleToPathElt(std::string &&s)
+static std::string &&
+TitleToPathSegment(std::string &&s)
 {
 	std::replace(s.begin(), s.end(), '/', '_');
-	return s;
+	return std::move(s);
 }
 
 /**
  * An XML parser which builds directory contents from DIDL lite input.
  */
 class UPnPDirParser final : public CommonExpatParser {
-	UPnPDirContent &m_dir;
+	UPnPDirContent &directory;
 
 	enum {
 		NONE,
@@ -120,22 +120,22 @@ class UPnPDirParser final : public CommonExpatParser {
 	 */
 	std::string value;
 
-	UPnPDirObject m_tobj;
+	UPnPDirObject object;
 	TagBuilder tag;
 
 public:
-	UPnPDirParser(UPnPDirContent& dir)
-		:m_dir(dir),
+	UPnPDirParser(UPnPDirContent &_directory)
+		:directory(_directory),
 		 state(NONE),
 		 tag_type(TAG_NUM_OF_ITEM_TYPES)
 	{
-		m_tobj.clear();
+		object.Clear();
 	}
 
 protected:
 	virtual void StartElement(const XML_Char *name, const XML_Char **attrs)
 	{
-		if (m_tobj.type != UPnPDirObject::Type::UNKNOWN &&
+		if (object.type != UPnPDirObject::Type::UNKNOWN &&
 		    tag_type == TAG_NUM_OF_ITEM_TYPES) {
 			tag_type = tag_table_lookup(upnp_tags, name);
 			if (tag_type != TAG_NUM_OF_ITEM_TYPES)
@@ -147,31 +147,31 @@ protected:
 		switch (name[0]) {
 		case 'c':
 			if (!strcmp(name, "container")) {
-				m_tobj.clear();
-				m_tobj.type = UPnPDirObject::Type::CONTAINER;
+				object.Clear();
+				object.type = UPnPDirObject::Type::CONTAINER;
 
 				const char *id = GetAttribute(attrs, "id");
 				if (id != nullptr)
-					m_tobj.m_id = id;
+					object.id = id;
 
 				const char *pid = GetAttribute(attrs, "parentID");
 				if (pid != nullptr)
-					m_tobj.m_pid = pid;
+					object.parent_id = pid;
 			}
 			break;
 
 		case 'i':
 			if (!strcmp(name, "item")) {
-				m_tobj.clear();
-				m_tobj.type = UPnPDirObject::Type::ITEM;
+				object.Clear();
+				object.type = UPnPDirObject::Type::ITEM;
 
 				const char *id = GetAttribute(attrs, "id");
 				if (id != nullptr)
-					m_tobj.m_id = id;
+					object.id = id;
 
 				const char *pid = GetAttribute(attrs, "parentID");
 				if (pid != nullptr)
-					m_tobj.m_pid = pid;
+					object.parent_id = pid;
 			}
 			break;
 
@@ -197,25 +197,15 @@ protected:
 		}
 	}
 
-	bool checkobjok() {
-		if (m_tobj.m_id.empty() || m_tobj.m_pid.empty() ||
-		    m_tobj.name.empty() ||
-		    (m_tobj.type == UPnPDirObject::Type::ITEM &&
-		     m_tobj.item_class == UPnPDirObject::ItemClass::UNKNOWN))
-			return false;
-
-		return true;
-	}
-
 	virtual void EndElement(const XML_Char *name)
 	{
 		if (tag_type != TAG_NUM_OF_ITEM_TYPES) {
-			assert(m_tobj.type != UPnPDirObject::Type::UNKNOWN);
+			assert(object.type != UPnPDirObject::Type::UNKNOWN);
 
 			tag.AddItem(tag_type, value.c_str());
 
 			if (tag_type == TAG_TITLE)
-				m_tobj.name = titleToPathElt(std::move(value));
+				object.name = TitleToPathSegment(std::move(value));
 
 			value.clear();
 			tag_type = TAG_NUM_OF_ITEM_TYPES;
@@ -223,9 +213,9 @@ protected:
 		}
 
 		if ((!strcmp(name, "container") || !strcmp(name, "item")) &&
-		    checkobjok()) {
-			tag.Commit(m_tobj.tag);
-			m_dir.objects.emplace_back(std::move(m_tobj));
+		    object.Check()) {
+			tag.Commit(object.tag);
+			directory.objects.emplace_back(std::move(object));
 		}
 
 		state = NONE;
@@ -234,7 +224,7 @@ protected:
 	virtual void CharacterData(const XML_Char *s, int len)
 	{
 		if (tag_type != TAG_NUM_OF_ITEM_TYPES) {
-			assert(m_tobj.type != UPnPDirObject::Type::UNKNOWN);
+			assert(object.type != UPnPDirObject::Type::UNKNOWN);
 
 			value.append(s, len);
 			return;
@@ -245,11 +235,11 @@ protected:
 			break;
 
 		case RES:
-			m_tobj.url.assign(s, len);
+			object.url.assign(s, len);
 			break;
 
 		case CLASS:
-			m_tobj.item_class = ParseItemClass(s, len);
+			object.item_class = ParseItemClass(s, len);
 			break;
 		}
 	}
diff --git a/src/db/plugins/upnp/Object.hxx b/src/db/plugins/upnp/Object.hxx
index 16a66c774..6d71c158b 100644
--- a/src/db/plugins/upnp/Object.hxx
+++ b/src/db/plugins/upnp/Object.hxx
@@ -21,6 +21,7 @@
 #define MPD_UPNP_OBJECT_HXX
 
 #include "tag/Tag.hxx"
+#include "Compiler.h"
 
 #include <string>
 
@@ -50,8 +51,16 @@ public:
 		PLAYLIST,
 	};
 
-	std::string m_id; // ObjectId
-	std::string m_pid; // Parent ObjectId
+	/**
+	 * ObjectId
+	 */
+	std::string id;
+
+	/**
+	 * Parent's ObjectId
+	 */
+	std::string parent_id;
+	
 	std::string url;
 
 	/**
@@ -71,15 +80,21 @@ public:
 
 	UPnPDirObject &operator=(UPnPDirObject &&) = default;
 
-	void clear()
-	{
-		m_id.clear();
-		m_pid.clear();
+	void Clear() {
+		id.clear();
+		parent_id.clear();
 		url.clear();
 		type = Type::UNKNOWN;
 		item_class = ItemClass::UNKNOWN;
 		tag.Clear();
 	}
+
+	gcc_pure
+	bool Check() const {
+		return !id.empty() && !parent_id.empty() && !name.empty() &&
+			(type != UPnPDirObject::Type::ITEM ||
+			 item_class != UPnPDirObject::ItemClass::UNKNOWN);
+	}
 };
 
 #endif /* _UPNPDIRCONTENT_H_X_INCLUDED_ */
diff --git a/src/db/plugins/upnp/UpnpDatabasePlugin.cxx b/src/db/plugins/upnp/UpnpDatabasePlugin.cxx
index 9970cdcf3..aea97aa8e 100644
--- a/src/db/plugins/upnp/UpnpDatabasePlugin.cxx
+++ b/src/db/plugins/upnp/UpnpDatabasePlugin.cxx
@@ -414,7 +414,7 @@ UpnpDatabase::SearchSongs(const ContentDirectoryService &server,
 		// So we return synthetic and ugly paths based on the object id,
 		// which we later have to detect.
 		const std::string path = songPath(server.getFriendlyName(),
-						  dirent.m_id);
+						  dirent.id);
 		if (!visitSong(std::move(dirent), path.c_str(),
 			       selection, visit_song,
 			       error))
@@ -449,13 +449,13 @@ UpnpDatabase::BuildPath(const ContentDirectoryService &server,
 			std::string &path,
 			Error &error) const
 {
-	const char *pid = idirent.m_id.c_str();
+	const char *pid = idirent.id.c_str();
 	path.clear();
 	UPnPDirObject dirent;
 	while (strcmp(pid, rootid) != 0) {
 		if (!ReadNode(server, pid, dirent, error))
 			return false;
-		pid = dirent.m_pid.c_str();
+		pid = dirent.parent_id.c_str();
 
 		if (path.empty())
 			path = dirent.name;
@@ -511,7 +511,7 @@ UpnpDatabase::Namei(const ContentDirectoryService &server,
 			return false;
 		}
 
-		objid = std::move(child->m_id);
+		objid = std::move(child->id);
 	}
 }
 
@@ -623,7 +623,7 @@ UpnpDatabase::VisitServer(const ContentDirectoryService &server,
 			}
 
 			std::string path = songPath(server.getFriendlyName(),
-						    dirent.m_id);
+						    dirent.id);
 			if (!visitSong(std::move(dirent), path.c_str(),
 				       selection,
 				       visit_song, error))
@@ -642,7 +642,7 @@ UpnpDatabase::VisitServer(const ContentDirectoryService &server,
 	   recursion (1-deep) here, which will handle the "add dir"
 	   case. */
 	if (selection.recursive && selection.filter)
-		return SearchSongs(server, tdirent.m_id.c_str(), selection,
+		return SearchSongs(server, tdirent.id.c_str(), selection,
 				   visit_song, error);
 
 	const char *const base_uri = selection.uri.empty()
@@ -660,7 +660,7 @@ UpnpDatabase::VisitServer(const ContentDirectoryService &server,
 	   and loop here, but it's not useful as mpd will only return
 	   data to the client when we're done anyway. */
 	UPnPDirContent dirbuf;
-	if (!server.readDir(handle, tdirent.m_id.c_str(), dirbuf,
+	if (!server.readDir(handle, tdirent.id.c_str(), dirbuf,
 			    error))
 		return false;
 
@@ -749,7 +749,7 @@ UpnpDatabase::VisitUniqueTags(const DatabaseSelection &selection,
 
 			const char *value = dirent.tag.GetValue(tag);
 			if (value != nullptr) {
-#if defined(__clang__) || GCC_CHECK_VERSION(4,8)
+#if CLANG_OR_GCC_VERSION(4,8)
 				values.emplace(value);
 #else
 				values.insert(value);