diff options
author | Max Kellermann <max@duempel.org> | 2014-10-25 20:42:50 +0200 |
---|---|---|
committer | Max Kellermann <max@duempel.org> | 2014-11-02 11:50:56 +0100 |
commit | f6b2899dd2f2b7985da0cf3734a7276ea54e23a2 (patch) | |
tree | 4fed604eb5df2a29e54981c5795417a398cc84a2 /test/run_encoder.cxx | |
parent | bccd4ef2f72f723b7abb1d7f6d004a70cad735aa (diff) | |
download | mpd-f6b2899dd2f2b7985da0cf3734a7276ea54e23a2.tar.gz mpd-f6b2899dd2f2b7985da0cf3734a7276ea54e23a2.tar.xz mpd-f6b2899dd2f2b7985da0cf3734a7276ea54e23a2.zip |
decoder/faad: remove workaround for ancient libfaad2 ABI bug
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit()
prototype in its header declared the "samplerate" parameter to be
"unsigned long *", but internally, the function assumed it was
"uint32_t *" instead. On 32 bit machines, that was no difference, but
on 64 bit, this left one portion of the return value uninitialized;
and worse, on big-endian, the wrong word was filled. This bug had to
be worked around in MPD (commit 9c4e97a6).
A few months later, the bug was fixed in the FAAD CVS in commit 1.117
on file libfaad/decoder.c; the commit message was:
"Use public headers internally to prevent duplicate declarations"
The commit message was too brief at best; the problem was not
duplicate declarations, but a prototype mismatch. No mention of the
bug fix in the ChangeLog.
The MPD project never learned about this bug fix, and so MPD would
always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6
years later, it's about time to fix this second ABI problem. Let's
kill the workaround!
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions