aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMax Kellermann <max@duempel.org>2013-12-29 13:58:39 +0100
committerMax Kellermann <max@duempel.org>2013-12-29 13:59:05 +0100
commite30b356eb018adcfb3efbce97c81bc0d99934826 (patch)
treecd3d054e225b244a270ab4c56d6cdc3f28485a14 /src
parent09a0803116e642be4e983d1d09295afc788f37ca (diff)
downloadmpd-e30b356eb018adcfb3efbce97c81bc0d99934826.tar.gz
mpd-e30b356eb018adcfb3efbce97c81bc0d99934826.tar.xz
mpd-e30b356eb018adcfb3efbce97c81bc0d99934826.zip
daemon: no initgroups() when already running as the configured user
We can assume that initgroups() would be a no-op in that case, however initgroups() is not allowed for unprivileged users anyway.
Diffstat (limited to 'src')
-rw-r--r--src/Daemon.cxx6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/Daemon.cxx b/src/Daemon.cxx
index d40c49d5d..557c47777 100644
--- a/src/Daemon.cxx
+++ b/src/Daemon.cxx
@@ -116,7 +116,11 @@ daemonize_set_user(void)
/* init supplementary groups
* (must be done before we change our uid)
*/
- if (!had_group && initgroups(user_name, user_gid) == -1) {
+ if (!had_group &&
+ /* no need to set the new user's supplementary groups if
+ we are already this user */
+ user_uid != getuid() &&
+ initgroups(user_name, user_gid) == -1) {
FormatFatalSystemError("Failed to set supplementary groups "
"of user \"%s\"",
user_name);