diff options
| author | Thomas Jansen <mithi@mithi.net> | 2010-09-25 15:00:43 +0200 |
|---|---|---|
| committer | Thomas Jansen <mithi@mithi.net> | 2010-09-25 15:00:43 +0200 |
| commit | 28bcb8bdf568875eeea1349e39b7958d77c8fcc1 (patch) | |
| tree | 17397be16e8067a48fd532a581081f68a1b17700 /src/update.c | |
| parent | 9af9fd140032138894e4781caabee8a5a96edab8 (diff) | |
| download | mpd-28bcb8bdf568875eeea1349e39b7958d77c8fcc1.tar.gz mpd-28bcb8bdf568875eeea1349e39b7958d77c8fcc1.tar.xz mpd-28bcb8bdf568875eeea1349e39b7958d77c8fcc1.zip | |
eliminate g_error() usage
Replaced all occurrences of g_error() with MPD_ERROR() located in a new header
file 'mpd_error.h'. This macro uses g_critical() to print the error message
and then exits gracefully in contrast to g_error() which would internally call
abort() to produce a core dump.
The macro name is distinctive and allows to find all places with dubious error
handling. The long-term goal is to get rid of MPD_ERROR() altogether. To
facilitate the eventual removal of this macro it was added in a new header
file rather than to an existing header file.
This fixes #2995 and #3007.
Diffstat (limited to 'src/update.c')
| -rw-r--r-- | src/update.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/update.c b/src/update.c index 83436612f..d57fb114d 100644 --- a/src/update.c +++ b/src/update.c @@ -28,6 +28,7 @@ #include "idle.h" #include "stats.h" #include "main.h" +#include "mpd_error.h" #include <glib.h> @@ -93,7 +94,7 @@ spawn_update_task(const char *path) update_thr = g_thread_create(update_task, g_strdup(path), TRUE, &e); if (update_thr == NULL) - g_error("Failed to spawn update task: %s", e->message); + MPD_ERROR("Failed to spawn update task: %s", e->message); if (++update_task_id > update_task_id_max) update_task_id = 1; |