aboutsummaryrefslogtreecommitdiffstats
path: root/src/sllist.c
diff options
context:
space:
mode:
authorEric Wong <normalperson@yhbt.net>2006-07-30 03:43:38 +0000
committerEric Wong <normalperson@yhbt.net>2006-07-30 03:43:38 +0000
commit4cf5d04ca15bc28ee4636d1dccb858763513e571 (patch)
tree7898902e786f5763643a513ea96bcada8a2559cc /src/sllist.c
parent4d5b8509eb46cff40890b781018669233a79e414 (diff)
downloadmpd-4cf5d04ca15bc28ee4636d1dccb858763513e571.tar.gz
mpd-4cf5d04ca15bc28ee4636d1dccb858763513e571.tar.xz
mpd-4cf5d04ca15bc28ee4636d1dccb858763513e571.zip
interface/connection malloc reductions from mpd-ke
This patch massively reduces the amount of heap allocations at the interface/command layer. Most commands with minimal output should not allocate memory from the heap at all. Things like repeatedly polling status, currentsong, and volume changes should be faster as a result, and more importantly, not a source of memory fragmentation. These changes should be safe in that there's no way for a remote-client to corrupt memory or otherwise do bad stuff to MPD, but an extra set of eyes to review would be good. Of course there's never any warranty :) No longer do we use FILE * structures in the interface, which means we don't have to allocate any new memory for most connections. Now, before you go on about losing the buffering that FILE * +implies+, remember that myfprintf() never took advantage of any of the stdio buffering features. To reduce the diff and make bugs easier to spot in the diff, I've kept myfprintf in places where we write to files (and not network interfaces). Expect myfprintf to go away entirely soon (we'll use fprintf for writing regular files). git-svn-id: https://svn.musicpd.org/mpd/trunk@4483 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Diffstat (limited to 'src/sllist.c')
-rw-r--r--src/sllist.c71
1 files changed, 71 insertions, 0 deletions
diff --git a/src/sllist.c b/src/sllist.c
new file mode 100644
index 000000000..1c11c973d
--- /dev/null
+++ b/src/sllist.c
@@ -0,0 +1,71 @@
+/* the Music Player Daemon (MPD)
+ * (c)2003-2006 by Warren Dukes (warren.dukes@gmail.com)
+ * This project's homepage is: http://www.musicpd.org
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+/* a very simple singly-linked-list structure for queues/buffers */
+
+#include "sllist.h"
+#include "utils.h"
+
+static void init_strnode(struct strnode *x, char *s)
+{
+ x->data = s;
+ x->next = NULL;
+}
+
+struct strnode *new_strnode(char *s)
+{
+ struct strnode *x = malloc(sizeof(struct strnode));
+ init_strnode(x, s);
+ return x;
+}
+
+struct strnode *new_strnode_dup(char *s, const size_t size)
+{
+ struct strnode *x = malloc(sizeof(struct strnode) + size);
+ x->next = NULL;
+ x->data = ((void *)x + sizeof(struct strnode));
+ memcpy((void *)x->data, (void*)s, size);
+ return x;
+}
+
+struct sllnode *new_sllnode(void *s, const size_t size)
+{
+ struct sllnode *x = malloc(sizeof(struct sllnode) + size);
+ x->next = NULL;
+ x->size = size;
+ x->data = ((void *)x + sizeof(struct sllnode));
+ memcpy(x->data, (void *)s, size);
+ return x;
+}
+
+struct strnode *dup_strlist(struct strnode *old)
+{
+ struct strnode *tmp, *new, *cur;
+
+ tmp = old;
+ cur = new = new_strnode_dup(tmp->data, strlen(tmp->data) + 1);
+ tmp = tmp->next;
+ while (tmp) {
+ cur->next = new_strnode_dup(tmp->data, strlen(tmp->data) + 1);
+ cur = cur->next;
+ tmp = tmp->next;
+ }
+ return new;
+}
+
+