diff options
| author | Eric Wong <normalperson@yhbt.net> | 2007-01-14 03:07:53 +0000 |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2007-01-14 03:07:53 +0000 |
| commit | b443363aa6081749883a92f9955a95c4301df00a (patch) | |
| tree | 7fa3aa1c9779167d9c8daa7fda640ecab64fd25c /src/player.c | |
| parent | 45716f877b940ffa38efc82d1692cbcc216caba2 (diff) | |
| download | mpd-b443363aa6081749883a92f9955a95c4301df00a.tar.gz mpd-b443363aa6081749883a92f9955a95c4301df00a.tar.xz mpd-b443363aa6081749883a92f9955a95c4301df00a.zip | |
Don't initialize globals to zero (or NULL)
Some compilers and linkers aren't smart enough to optimize this,
as global variables are implictly initialized to zero. As a
result, binaries are a bit smaller as more goes in the .bss and
less in the text section.
git-svn-id: https://svn.musicpd.org/mpd/trunk@5254 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Diffstat (limited to '')
| -rw-r--r-- | src/player.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/player.c b/src/player.c index 6e2e11afe..b976dce7f 100644 --- a/src/player.c +++ b/src/player.c @@ -297,7 +297,7 @@ int getPlayerError(void) char *getPlayerErrorStr(void) { - static char *error = NULL; + static char *error; int errorlen = MAXPATHLEN + 1024; PlayerControl *pc = &(getPlayerData()->playerControl); @@ -504,8 +504,8 @@ void playerCycleLogFiles(void) /* this actually creates a dupe of the current metadata */ Song *playerCurrentDecodeSong(void) { - static Song *song = NULL; - static MetadataChunk *prev = NULL; + static Song *song; + static MetadataChunk *prev; Song *ret = NULL; PlayerControl *pc = &(getPlayerData()->playerControl); |