eliminate g_error() usage

Replaced all occurrences of g_error() with MPD_ERROR() located in a new header
file 'mpd_error.h'. This macro uses g_critical() to print the error message
and then exits gracefully in contrast to g_error() which would internally call
abort() to produce a core dump.

The macro name is distinctive and allows to find all places with dubious error
handling. The long-term goal is to get rid of MPD_ERROR() altogether. To
facilitate the eventual removal of this macro it was added in a new header
file rather than to an existing header file.

This fixes #2995 and #3007.

1 files changed, 6 insertions, 5 deletions

diff --git a/src/output_all.c b/src/output_all.c
index dbd5a6ce6..3f582dcb4 100644
--- a/src/output_all.c
+++ b/src/output_all.c
@@ -26,6 +26,7 @@
 #include "pipe.h"
 #include "buffer.h"
 #include "player_control.h"
+#include "mpd_error.h"
 
 #ifndef NDEBUG
 #include "chunk.h"
@@ -122,17 +123,17 @@ audio_output_all_init(void)
 
 		if (!audio_output_init(output, param, &error)) {
 			if (param != NULL)
-				g_error("line %i: %s",
-					param->line, error->message);
+				MPD_ERROR("line %i: %s",
+					  param->line, error->message)
 			else
-				g_error("%s", error->message);
+				MPD_ERROR("%s", error->message);
 		}
 
 		/* require output names to be unique: */
 		for (j = 0; j < i; j++) {
 			if (!strcmp(output->name, audio_outputs[j].name)) {
-				g_error("output devices with identical "
-					"names: %s\n", output->name);
+				MPD_ERROR("output devices with identical "
+					  "names: %s\n", output->name);
 			}
 		}
 	}