replay_gain: optionally use hardware mixer to apply replay gain

Add an option for each audio output which enables the use of the
hardware mixer, instead of the software volume code.

This is hardware specific, and assumes linear volume control.  This is
not the case for hardware mixers which were tested, making this patch
somewhat useless, but we will use it to experiment with the settings,
to find a good solution.

2 files changed, 30 insertions, 6 deletions

diff --git a/src/output_init.c b/src/output_init.c
index 387915ddc..f3d22ace1 100644
--- a/src/output_init.c
+++ b/src/output_init.c
@@ -32,6 +32,7 @@
 #include "filter_config.h"
 #include "filter/chain_filter_plugin.h"
 #include "filter/autoconvert_filter_plugin.h"
+#include "filter/replay_gain_filter_plugin.h"
 
 #include <glib.h>
 
@@ -196,12 +197,19 @@ audio_output_init(struct audio_output *ao, const struct config_param *param,
 
 	/* create the replay_gain filter */
 
-	ao->replay_gain_filter = filter_new(&replay_gain_filter_plugin,
-					    param, NULL);
-	assert(ao->replay_gain_filter != NULL);
+	const char *replay_gain_handler =
+		config_get_block_string(param, "replay_gain_handler",
+					"software");
 
-	filter_chain_append(ao->filter, ao->replay_gain_filter);
-	ao->replay_gain_serial = 0;
+	if (strcmp(replay_gain_handler, "none") != 0) {
+		ao->replay_gain_filter = filter_new(&replay_gain_filter_plugin,
+						    param, NULL);
+		assert(ao->replay_gain_filter != NULL);
+
+		filter_chain_append(ao->filter, ao->replay_gain_filter);
+		ao->replay_gain_serial = 0;
+	} else
+		ao->replay_gain_filter = NULL;
 
 	/* create the normalization filter (if configured) */
 
@@ -247,6 +255,21 @@ audio_output_init(struct audio_output *ao, const struct config_param *param,
 		g_error_free(error);
 	}
 
+	/* use the hardware mixer for replay gain? */
+
+	if (strcmp(replay_gain_handler, "mixer") == 0) {
+		if (ao->mixer != NULL)
+			replay_gain_filter_set_mixer(ao->replay_gain_filter,
+						     ao->mixer, 100);
+		else
+			g_warning("No such mixer for output '%s'", ao->name);
+	} else if (strcmp(replay_gain_handler, "software") != 0 &&
+		   ao->replay_gain_filter != NULL) {
+		g_set_error(error_r, audio_output_quark(), 0,
+			    "Invalid \"replay_gain_handler\" value");
+		return false;
+	}
+
 	/* the "convert" filter must be the last one in the chain */
 
 	ao->convert_filter = filter_new(&convert_filter_plugin, NULL, NULL);
diff --git a/src/output_thread.c b/src/output_thread.c
index 0e34c64b7..4bf0827f6 100644
--- a/src/output_thread.c
+++ b/src/output_thread.c
@@ -264,7 +264,8 @@ ao_play_chunk(struct audio_output *ao, const struct music_chunk *chunk)
 
 	/* update replay gain */
 
-	if (chunk->replay_gain_serial != ao->replay_gain_serial) {
+	if (ao->replay_gain_filter != NULL &&
+	    chunk->replay_gain_serial != ao->replay_gain_serial) {
 		replay_gain_filter_set_info(ao->replay_gain_filter,
 					    chunk->replay_gain_serial != 0
 					    ? &chunk->replay_gain_info