diff options
| author | Max Kellermann <max@duempel.org> | 2008-03-26 10:38:07 +0000 |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2008-03-26 10:38:07 +0000 |
| commit | 27f12c173d57d09d095d0e5ecfeb18acf5d2434a (patch) | |
| tree | a1016cf4f069f0ab804f3023c87eb494c45dfed2 /src/myfprintf.c | |
| parent | 0692f6cd0ab12e921d1897de215fb42d6dc79a7c (diff) | |
| download | mpd-27f12c173d57d09d095d0e5ecfeb18acf5d2434a.tar.gz mpd-27f12c173d57d09d095d0e5ecfeb18acf5d2434a.tar.xz mpd-27f12c173d57d09d095d0e5ecfeb18acf5d2434a.zip | |
use size_t
When dealing with in-memory lengths, the standard type "size_t" should
be used. Missing one can be quite dangerous, because an attacker
could provoke an integer under-/overflow, which may provide an attack
vector.
git-svn-id: https://svn.musicpd.org/mpd/trunk@7205 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Diffstat (limited to 'src/myfprintf.c')
| -rw-r--r-- | src/myfprintf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/myfprintf.c b/src/myfprintf.c index fdea2b78f..2f8ea7723 100644 --- a/src/myfprintf.c +++ b/src/myfprintf.c @@ -30,7 +30,7 @@ static void blockingWrite(const int fd, const char *string, size_t len) { while (len) { ssize_t ret = xwrite(fd, string, len); - if (ret == len) + if (ret == (ssize_t)len) return; if (ret >= 0) { len -= ret; |