diff options
author | Eric Wong <normalperson@yhbt.net> | 2008-04-12 09:46:11 +0000 |
---|---|---|
committer | Eric Wong <normalperson@yhbt.net> | 2008-04-12 09:46:11 +0000 |
commit | baf9b94ecf3872f35717c3236a0040160ec99aef (patch) | |
tree | ca6113fe6fb4199a9eb8b93134b376ae9786c1cd /src/main_notify.h | |
parent | 804088f5901fcc20cc80fb1dba6960703fc3cdf7 (diff) | |
download | mpd-baf9b94ecf3872f35717c3236a0040160ec99aef.tar.gz mpd-baf9b94ecf3872f35717c3236a0040160ec99aef.tar.xz mpd-baf9b94ecf3872f35717c3236a0040160ec99aef.zip |
Fix the problem of songs not advancing without client activity
The select() in the main event loop blocks now (saving us many
unnecessary wakeups). This interacted badly with the threads
that were trying to wakeup the main task via
pthread_cond_signal() since the main task was not blocked
on a condition variable, but on select().
So now if we detect a need to wakeup the player, we write
to a pipe which select() is watching instead of blindly
calling pthread_cond_signal().
git-svn-id: https://svn.musicpd.org/mpd/trunk@7347 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Diffstat (limited to '')
-rw-r--r-- | src/main_notify.h | 34 |
1 files changed, 34 insertions, 0 deletions
diff --git a/src/main_notify.h b/src/main_notify.h new file mode 100644 index 000000000..c7bba4440 --- /dev/null +++ b/src/main_notify.h @@ -0,0 +1,34 @@ +/* the Music Player Daemon (MPD) + * Copyright (C) 2003-2007 Warren Dukes <warren.dukes@gmail.com> + * Copyright (C) 2008 Eric Wong <normalperson@yhbt.net> + * + * This project's homepage is: http://www.musicpd.org + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + */ + +#ifndef MAIN_NOTIFY_H +#define MAIN_NOTIFY_H + +void init_main_notify(void); + +void wakeup_main_task(void); + +void wait_main_task(void); + +void main_notify_lock(void); + +void main_notify_unlock(void); + +#endif /* MAIN_NOTIFY_H */ |