set the close-on-exec flag on all file descriptors

Added the "fd_util" library, which attempts to use the new thread-safe
Linux system calls pipe2(), accept4() and the options O_CLOEXEC,
SOCK_CLOEXEC.  Without these, it falls back to FD_CLOEXEC, which is
not thread safe.

This is particularly important for the "pipe" output plugin (and
others, such as JACK/PulseAudio), because we were heavily leaking file
descriptors to child processes.

1 files changed, 2 insertions, 1 deletions

diff --git a/src/log.c b/src/log.c
index 3a9795d7d..b2de391bd 100644
--- a/src/log.c
+++ b/src/log.c
@@ -20,6 +20,7 @@
 #include "log.h"
 #include "conf.h"
 #include "utils.h"
+#include "fd_util.h"
 #include "config.h"
 
 #include <assert.h>
@@ -128,7 +129,7 @@ open_log_file(void)
 {
 	assert(out_filename != NULL);
 
-	return open(out_filename, O_CREAT | O_WRONLY | O_APPEND, 0666);
+	return open_cloexec(out_filename, O_CREAT | O_WRONLY | O_APPEND);
 }
 
 static void