diff options
| author | Max Kellermann <max@duempel.org> | 2008-04-12 04:07:11 +0000 |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2008-04-12 04:07:11 +0000 |
| commit | 623a86f389dc3c1cce52b1d0e6ef64d27b26f023 (patch) | |
| tree | be24c359d81fab206eb9dd34706a5c9c5d8316c9 /src/listen.c | |
| parent | 83e937320b947b4f70600f7517f64ec81c87e289 (diff) | |
| download | mpd-623a86f389dc3c1cce52b1d0e6ef64d27b26f023.tar.gz mpd-623a86f389dc3c1cce52b1d0e6ef64d27b26f023.tar.xz mpd-623a86f389dc3c1cce52b1d0e6ef64d27b26f023.zip | |
use constant pointers when possible
It is a good practice to constify pointers when their dereferenced
data is not modified within the functions or its descendants.
git-svn-id: https://svn.musicpd.org/mpd/trunk@7234 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Diffstat (limited to 'src/listen.c')
| -rw-r--r-- | src/listen.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/listen.c b/src/listen.c index a22427095..78bb6ace1 100644 --- a/src/listen.c +++ b/src/listen.c @@ -67,7 +67,7 @@ static void redirect_stdin(void) FATAL("dup2 stdin: %s\n", strerror(errno)); } -static int establishListen(struct sockaddr *addrp, socklen_t addrlen) +static int establishListen(const struct sockaddr *addrp, socklen_t addrlen) { int pf; int sock; @@ -121,7 +121,7 @@ static int establishListen(struct sockaddr *addrp, socklen_t addrlen) static void parseListenConfigParam(unsigned int port, ConfigParam * param) { - struct sockaddr *addrp; + const struct sockaddr *addrp; socklen_t addrlen; struct sockaddr_in sin4; #ifdef HAVE_IPV6 @@ -141,14 +141,14 @@ static void parseListenConfigParam(unsigned int port, ConfigParam * param) #ifdef HAVE_IPV6 if (useIpv6) { sin6.sin6_addr = in6addr_any; - addrp = (struct sockaddr *)&sin6; + addrp = (const struct sockaddr *)&sin6; addrlen = sizeof(struct sockaddr_in6); if (establishListen(addrp, addrlen) < 0) BINDERROR(); } #endif sin4.sin_addr.s_addr = INADDR_ANY; - addrp = (struct sockaddr *)&sin4; + addrp = (const struct sockaddr *)&sin4; addrlen = sizeof(struct sockaddr_in); #ifdef HAVE_IPV6 if ((establishListen(addrp, addrlen) < 0) && !useIpv6) { @@ -173,14 +173,14 @@ static void parseListenConfigParam(unsigned int port, ConfigParam * param) param->value, param->line); } memcpy((char *)&sin6.sin6_addr.s6_addr, - (char *)he->h_addr, he->h_length); - addrp = (struct sockaddr *)&sin6; + (const char *)he->h_addr, he->h_length); + addrp = (const struct sockaddr *)&sin6; addrlen = sizeof(struct sockaddr_in6); break; #endif case AF_INET: memcpy((char *)&sin4.sin_addr.s_addr, - (char *)he->h_addr, he->h_length); + (const char *)he->h_addr, he->h_length); addrp = (struct sockaddr *)&sin4; addrlen = sizeof(struct sockaddr_in); break; |