diff options
| author | Max Kellermann <max@duempel.org> | 2008-09-18 01:07:16 +0200 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2008-09-18 01:07:16 +0200 |
| commit | 44c3a54cf0d0f65627a5993a129b324107f9fc58 (patch) | |
| tree | 857441cf5d7f4da02a09f608ee183300b3c8d676 /src/libmpdclient.c | |
| parent | 96683ca4d3611e7c25364a1dbf326435727757d2 (diff) | |
| download | mpd-44c3a54cf0d0f65627a5993a129b324107f9fc58.tar.gz mpd-44c3a54cf0d0f65627a5993a129b324107f9fc58.tar.xz mpd-44c3a54cf0d0f65627a5993a129b324107f9fc58.zip | |
libmpdclient: smaller input buffer
Even for large responses, 16kB should be enough. There is no
performance gain for larger buffers, even if MPD is local.
Diffstat (limited to '')
| -rw-r--r-- | src/libmpdclient.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/libmpdclient.c b/src/libmpdclient.c index b29ffe746..1b0851ff1 100644 --- a/src/libmpdclient.c +++ b/src/libmpdclient.c @@ -417,7 +417,7 @@ mpd_Connection * mpd_newConnection(const char * host, int port, float timeout) { ssize_t readed; readed = recv(connection->sock, &(connection->buffer[connection->buflen]), - MPD_BUFFER_MAX_LENGTH-connection->buflen,0); + sizeof(connection->buffer) - connection->buflen, 0); if(readed<=0) { snprintf(connection->errorStr, sizeof(connection->errorStr), "problems getting a response from" @@ -553,14 +553,14 @@ static void mpd_getNextReturnElement(mpd_Connection * connection) { !(rt = memchr(bufferCheck, '\n', connection->buffer + connection->buflen - bufferCheck))) { - if (connection->buflen >= MPD_BUFFER_MAX_LENGTH) { + if (connection->buflen >= sizeof(connection->buffer)) { memmove(connection->buffer, connection->buffer + connection->bufstart, connection->buflen - connection->bufstart); connection->buflen -= connection->bufstart; connection->bufstart = 0; } - if (connection->buflen >= MPD_BUFFER_MAX_LENGTH) { + if (connection->buflen >= sizeof(connection->buffer)) { strcpy(connection->errorStr,"buffer overrun"); connection->error = MPD_ERROR_BUFFEROVERRUN; connection->doneProcessing = 1; @@ -575,7 +575,7 @@ static void mpd_getNextReturnElement(mpd_Connection * connection) { if((err = select(connection->sock+1,&fds,NULL,NULL,&tv) == 1)) { readed = recv(connection->sock, connection->buffer+connection->buflen, - MPD_BUFFER_MAX_LENGTH-connection->buflen, + sizeof(connection->buffer) - connection->buflen, MSG_DONTWAIT); if(readed<0 && SENDRECV_ERRNO_IGNORE) { continue; |