aboutsummaryrefslogtreecommitdiffstats
path: root/src/lib/nfs/Cancellable.hxx
diff options
context:
space:
mode:
authorMax Kellermann <max@duempel.org>2014-12-14 15:56:53 +0100
committerMax Kellermann <max@duempel.org>2014-12-14 16:02:47 +0100
commita543627abd19f321ddd4259e222e6437e8312417 (patch)
tree9a0494216cc13a0785d972f762c556c0718e3335 /src/lib/nfs/Cancellable.hxx
parent80f2ba7fca533de38575bdaf737ea89284ed2b7b (diff)
downloadmpd-a543627abd19f321ddd4259e222e6437e8312417.tar.gz
mpd-a543627abd19f321ddd4259e222e6437e8312417.tar.xz
mpd-a543627abd19f321ddd4259e222e6437e8312417.zip
lib/nfs/Connection: fix memory leak (and assertion failure)
nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles.
Diffstat (limited to 'src/lib/nfs/Cancellable.hxx')
-rw-r--r--src/lib/nfs/Cancellable.hxx6
1 files changed, 6 insertions, 0 deletions
diff --git a/src/lib/nfs/Cancellable.hxx b/src/lib/nfs/Cancellable.hxx
index be4527ac3..151be0528 100644
--- a/src/lib/nfs/Cancellable.hxx
+++ b/src/lib/nfs/Cancellable.hxx
@@ -157,6 +157,12 @@ public:
return *i;
}
+
+ template<typename F>
+ void ForEach(F &&f) {
+ for (CT &i : list)
+ f(i);
+ }
};
#endif