diff options
| author | Max Kellermann <max@duempel.org> | 2009-10-11 23:32:22 +0200 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-10-11 23:32:22 +0200 |
| commit | 727c301fbcd285ff781f2d9b538973ca6a4ebcef (patch) | |
| tree | f75711b0035fdfb1e3a4f3e529ef5ffd9ef81d45 /src/input_stream.c | |
| parent | 71f881d5cb40fbb77a77a8b50b8d662acaa84310 (diff) | |
| download | mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.tar.gz mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.tar.xz mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.zip | |
input_stream: use "goffset" instead of "off_t"
The "off_t" type may change when you enable or disable large file
support on 32 bit platforms. This caused severe ABI problems within
MPD when we enabled LFS for the first time: two sources included
config.h and sys/types.h in different order, and had different off_t
sizes - leading to memory corruption because of ABI incompatibility.
This patch attempts to get rid of all public "off_t" uses: it removes
"off_t" from the input_stream ABI/API, and switches to GLib's 64 bit
"goffset" type. This may hurt 32 bit embedded platforms a tiny bit,
but that's not even measurable.
Diffstat (limited to '')
| -rw-r--r-- | src/input_stream.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/input_stream.c b/src/input_stream.c index 6c07da98f..98a660a7c 100644 --- a/src/input_stream.c +++ b/src/input_stream.c @@ -139,7 +139,7 @@ input_stream_open(struct input_stream *is, const char *url) } bool -input_stream_seek(struct input_stream *is, off_t offset, int whence) +input_stream_seek(struct input_stream *is, goffset offset, int whence) { if (is->plugin->seek == NULL) return false; |