diff options
| author | Eric Wong <normalperson@yhbt.net> | 2008-08-19 03:31:25 -0700 |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2008-08-19 03:31:25 -0700 |
| commit | 548385ac6cc0bc344762e19117f94258e7ea2251 (patch) | |
| tree | dcd2bae159f63d7a234d3ff740402aceea47dfcf /src/inputPlugins | |
| parent | 3befb84a6a7a95de7e0e94c2f0bd9936ecb60668 (diff) | |
| download | mpd-548385ac6cc0bc344762e19117f94258e7ea2251.tar.gz mpd-548385ac6cc0bc344762e19117f94258e7ea2251.tar.xz mpd-548385ac6cc0bc344762e19117f94258e7ea2251.zip | |
fix output buffer deadlock when daemonizing
We spawned the output buffer thread before daemonizing in
initPlayerData(), which is ultra bad because daemonizes forks
and threads are not preserved on exit. Since playerData has
been stripped bare by this core-rewrite anyways, move this code
into the outputBuffer_* group and drop playerData.[ch]
completely
I completely forgot to test this :<
Diffstat (limited to 'src/inputPlugins')
| -rw-r--r-- | src/inputPlugins/audiofile_plugin.c | 1 | ||||
| -rw-r--r-- | src/inputPlugins/mod_plugin.c | 1 | ||||
| -rw-r--r-- | src/inputPlugins/wavpack_plugin.c | 1 |
3 files changed, 0 insertions, 3 deletions
diff --git a/src/inputPlugins/audiofile_plugin.c b/src/inputPlugins/audiofile_plugin.c index 8178972ff..114a87786 100644 --- a/src/inputPlugins/audiofile_plugin.c +++ b/src/inputPlugins/audiofile_plugin.c @@ -26,7 +26,6 @@ #include "../audio.h" #include "../log.h" #include "../pcm_utils.h" -#include "../playerData.h" #include "../os_compat.h" #include <audiofile.h> diff --git a/src/inputPlugins/mod_plugin.c b/src/inputPlugins/mod_plugin.c index cfa7d6e3d..9f9da6273 100644 --- a/src/inputPlugins/mod_plugin.c +++ b/src/inputPlugins/mod_plugin.c @@ -24,7 +24,6 @@ #include "../audio.h" #include "../log.h" #include "../pcm_utils.h" -#include "../playerData.h" #include "../os_compat.h" #include <mikmod.h> diff --git a/src/inputPlugins/wavpack_plugin.c b/src/inputPlugins/wavpack_plugin.c index ef02712d7..2538be326 100644 --- a/src/inputPlugins/wavpack_plugin.c +++ b/src/inputPlugins/wavpack_plugin.c @@ -26,7 +26,6 @@ #include "../audio.h" #include "../log.h" #include "../pcm_utils.h" -#include "../playerData.h" #include "../outputBuffer.h" #include "../os_compat.h" #include "../path.h" |