diff options
| author | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
| commit | e3af0032b236dc52d4a74c4d740e57a1f6d520aa (patch) | |
| tree | 3984233a9b639e71ad80b4f6598539de3a27a008 /src/input | |
| parent | 9b21152600071ec46c021c8ba3b2ef69c90f039f (diff) | |
| download | mpd-e3af0032b236dc52d4a74c4d740e57a1f6d520aa.tar.gz mpd-e3af0032b236dc52d4a74c4d740e57a1f6d520aa.tar.xz mpd-e3af0032b236dc52d4a74c4d740e57a1f6d520aa.zip | |
set the close-on-exec flag on all file descriptors
Added the "fd_util" library, which attempts to use the new thread-safe
Linux system calls pipe2(), accept4() and the options O_CLOEXEC,
SOCK_CLOEXEC. Without these, it falls back to FD_CLOEXEC, which is
not thread safe.
This is particularly important for the "pipe" output plugin (and
others, such as JACK/PulseAudio), because we were heavily leaking file
descriptors to child processes.
Diffstat (limited to '')
| -rw-r--r-- | src/input/file_input_plugin.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/input/file_input_plugin.c b/src/input/file_input_plugin.c index 07c1e4ed6..55b495f38 100644 --- a/src/input/file_input_plugin.c +++ b/src/input/file_input_plugin.c @@ -20,6 +20,7 @@ #include "config.h" /* must be first for large file support */ #include "input/file_input_plugin.h" #include "input_plugin.h" +#include "fd_util.h" #include <sys/stat.h> #include <fcntl.h> @@ -50,7 +51,7 @@ input_file_open(struct input_stream *is, const char *filename) *slash = '\0'; } - fd = open(pathname, O_RDONLY); + fd = open_cloexec(pathname, O_RDONLY); if (fd < 0) { is->error = errno; g_debug("Failed to open \"%s\": %s", |