diff options
| author | Max Kellermann <max@duempel.org> | 2009-10-11 23:32:22 +0200 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-10-11 23:32:22 +0200 |
| commit | 727c301fbcd285ff781f2d9b538973ca6a4ebcef (patch) | |
| tree | f75711b0035fdfb1e3a4f3e529ef5ffd9ef81d45 /src/input/lastfm_input_plugin.c | |
| parent | 71f881d5cb40fbb77a77a8b50b8d662acaa84310 (diff) | |
| download | mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.tar.gz mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.tar.xz mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.zip | |
input_stream: use "goffset" instead of "off_t"
The "off_t" type may change when you enable or disable large file
support on 32 bit platforms. This caused severe ABI problems within
MPD when we enabled LFS for the first time: two sources included
config.h and sys/types.h in different order, and had different off_t
sizes - leading to memory corruption because of ABI incompatibility.
This patch attempts to get rid of all public "off_t" uses: it removes
"off_t" from the input_stream ABI/API, and switches to GLib's 64 bit
"goffset" type. This may hurt 32 bit embedded platforms a tiny bit,
but that's not even measurable.
Diffstat (limited to 'src/input/lastfm_input_plugin.c')
| -rw-r--r-- | src/input/lastfm_input_plugin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/input/lastfm_input_plugin.c b/src/input/lastfm_input_plugin.c index 4de62dc3b..4e13cd0ad 100644 --- a/src/input/lastfm_input_plugin.c +++ b/src/input/lastfm_input_plugin.c @@ -285,7 +285,7 @@ lastfm_input_eof_wrap(struct input_stream *is) } static bool -lastfm_input_seek_wrap(struct input_stream *is, off_t offset, int whence) +lastfm_input_seek_wrap(struct input_stream *is, goffset offset, int whence) { bool ret; struct lastfm_input *d = is->data; |