diff options
| author | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-11-07 18:55:16 +0100 |
| commit | e3af0032b236dc52d4a74c4d740e57a1f6d520aa (patch) | |
| tree | 3984233a9b639e71ad80b4f6598539de3a27a008 /src/event_pipe.c | |
| parent | 9b21152600071ec46c021c8ba3b2ef69c90f039f (diff) | |
| download | mpd-e3af0032b236dc52d4a74c4d740e57a1f6d520aa.tar.gz mpd-e3af0032b236dc52d4a74c4d740e57a1f6d520aa.tar.xz mpd-e3af0032b236dc52d4a74c4d740e57a1f6d520aa.zip | |
set the close-on-exec flag on all file descriptors
Added the "fd_util" library, which attempts to use the new thread-safe
Linux system calls pipe2(), accept4() and the options O_CLOEXEC,
SOCK_CLOEXEC. Without these, it falls back to FD_CLOEXEC, which is
not thread safe.
This is particularly important for the "pipe" output plugin (and
others, such as JACK/PulseAudio), because we were heavily leaking file
descriptors to child processes.
Diffstat (limited to 'src/event_pipe.c')
| -rw-r--r-- | src/event_pipe.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/event_pipe.c b/src/event_pipe.c index 3e5009150..17e11097a 100644 --- a/src/event_pipe.c +++ b/src/event_pipe.c @@ -19,6 +19,7 @@ #include "event_pipe.h" #include "utils.h" +#include "fd_util.h" #include <stdbool.h> #include <assert.h> @@ -84,11 +85,7 @@ void event_pipe_init(void) GIOChannel *channel; int ret; -#ifdef WIN32 - ret = _pipe(event_pipe, 512, _O_BINARY); -#else - ret = pipe(event_pipe); -#endif + ret = pipe_cloexec(event_pipe); if (ret < 0) g_error("Couldn't open pipe: %s", strerror(errno)); #ifndef WIN32 |