diff options
| author | J. Alexander Treuman <jat@spatialrift.net> | 2007-08-27 21:18:35 +0000 |
|---|---|---|
| committer | J. Alexander Treuman <jat@spatialrift.net> | 2007-08-27 21:18:35 +0000 |
| commit | 1b045d0672cb1a069efd2d150d81ae3d5253ada5 (patch) | |
| tree | 39080f9f722639ffef7b98441942052c9d5e4025 /src/directory.c | |
| parent | 752bf24b7475d89e97a450bab353f3a1892a1ce0 (diff) | |
| download | mpd-1b045d0672cb1a069efd2d150d81ae3d5253ada5.tar.gz mpd-1b045d0672cb1a069efd2d150d81ae3d5253ada5.tar.xz mpd-1b045d0672cb1a069efd2d150d81ae3d5253ada5.zip | |
removing debug messages from signal handlers
As unfortunate as it is to remove such useful debugging messages, it's
necessary to fix a potential deadlock with signal handling. A bunch of
functions the debug functions call aren't safe to call from a signal
handler. There are some alternate solutions, but they're neither pretty
nor simple. So just remove them entirely for now.
git-svn-id: https://svn.musicpd.org/mpd/trunk@6828 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Diffstat (limited to '')
| -rw-r--r-- | src/directory.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/directory.c b/src/directory.c index adfd1f238..2a7e37def 100644 --- a/src/directory.c +++ b/src/directory.c @@ -130,20 +130,22 @@ void directory_sigChldHandler(int pid, int status) { if (directory_updatePid == pid) { if (WIFSIGNALED(status) && WTERMSIG(status) != SIGTERM) { - ERROR("update process died from a " - "non-TERM signal: %i\n", WTERMSIG(status)); + /* ERROR("update process died from a " + "non-TERM signal: %i\n", WTERMSIG(status)); */ } else if (!WIFSIGNALED(status)) { switch (WEXITSTATUS(status)) { case DIRECTORY_UPDATE_EXIT_UPDATE: directory_reReadDB = 1; - DEBUG("directory_sigChldHandler: " - "updated db\n"); + /* DEBUG("directory_sigChldHandler: " + "updated db\n"); */ case DIRECTORY_UPDATE_EXIT_NOUPDATE: - DEBUG("directory_sigChldHandler: " - "update exited succesffully\n"); + /* DEBUG("directory_sigChldHandler: " + "update exited succesffully\n"); */ break; + /* default: ERROR("error updating db\n"); + */ } } clearUpdatePid(); |