diff options
| author | Max Kellermann <max@duempel.org> | 2008-09-26 09:57:11 +0200 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2008-09-26 09:57:11 +0200 |
| commit | 58554e14f9995fdafe2338a69a42d9192b96f712 (patch) | |
| tree | 83881d1e2131795581c822aa5cd01ddce42cf80f /src/decoder_thread.c | |
| parent | 323e86489fb9544b3a2faa9e9004ac0b72bf01ca (diff) | |
| download | mpd-58554e14f9995fdafe2338a69a42d9192b96f712.tar.gz mpd-58554e14f9995fdafe2338a69a42d9192b96f712.tar.xz mpd-58554e14f9995fdafe2338a69a42d9192b96f712.zip | |
notify: protect notify->pending with the mutex
There was a known deadlocking bug in the notify library: when the
other thread set notify->pending after the according check in
notify_wait(), the latter thread was deadlocked. Resolve this by
synchronizing all accesses to notify->pending with the notify object's
mutex. Since notify_signal_sync() was never used, we can remove it.
As a consequence, we don't need notify_enter() and notify_leave()
anymore; eliminate them, too.
Diffstat (limited to 'src/decoder_thread.c')
| -rw-r--r-- | src/decoder_thread.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/decoder_thread.c b/src/decoder_thread.c index 60381b1f6..0b2a6dc2d 100644 --- a/src/decoder_thread.c +++ b/src/decoder_thread.c @@ -167,8 +167,6 @@ stop_no_close: static void * decoder_task(mpd_unused void *arg) { - notify_enter(&dc.notify); - while (1) { assert(dc.state == DECODE_STATE_STOP); |