diff options
| author | Max Kellermann <max@duempel.org> | 2009-04-28 09:29:11 +0200 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-04-28 09:29:11 +0200 |
| commit | d5b3dd36fdc1f2924398f8c8b948f1b5cd9068a0 (patch) | |
| tree | 69e354ef73629f01d60c680e3e6c82322ecffc22 /src/decoder/mp4ff_plugin.c | |
| parent | 9038882d953f25d9f0d7c00cb073cd9430754333 (diff) | |
| download | mpd-d5b3dd36fdc1f2924398f8c8b948f1b5cd9068a0.tar.gz mpd-d5b3dd36fdc1f2924398f8c8b948f1b5cd9068a0.tar.xz mpd-d5b3dd36fdc1f2924398f8c8b948f1b5cd9068a0.zip | |
mp4ff_decoder: use g_ascii_strcasecmp() instead of strcasecmp()
strcasecmp() is locale dependent, making it a bad choice for internal
string comparisons.
Diffstat (limited to '')
| -rw-r--r-- | src/decoder/mp4ff_plugin.c | 17 |
1 files changed, 9 insertions, 8 deletions
diff --git a/src/decoder/mp4ff_plugin.c b/src/decoder/mp4ff_plugin.c index 17eb7acdb..cf9382904 100644 --- a/src/decoder/mp4ff_plugin.c +++ b/src/decoder/mp4ff_plugin.c @@ -394,21 +394,22 @@ mp4_tag_dup(const char *file) mp4ff_meta_get_by_index(mp4fh, i, &item, &value); - if (0 == strcasecmp("artist", item)) { + if (0 == g_ascii_strcasecmp("artist", item)) { tag_add_item(ret, TAG_ITEM_ARTIST, value); - } else if (0 == strcasecmp("title", item)) { + } else if (0 == g_ascii_strcasecmp("title", item)) { tag_add_item(ret, TAG_ITEM_TITLE, value); - } else if (0 == strcasecmp("album", item)) { + } else if (0 == g_ascii_strcasecmp("album", item)) { tag_add_item(ret, TAG_ITEM_ALBUM, value); - } else if (0 == strcasecmp("track", item)) { + } else if (0 == g_ascii_strcasecmp("track", item)) { tag_add_item(ret, TAG_ITEM_TRACK, value); - } else if (0 == strcasecmp("disc", item)) { /* Is that the correct id? */ + } else if (0 == g_ascii_strcasecmp("disc", item)) { + /* Is that the correct id? */ tag_add_item(ret, TAG_ITEM_DISC, value); - } else if (0 == strcasecmp("genre", item)) { + } else if (0 == g_ascii_strcasecmp("genre", item)) { tag_add_item(ret, TAG_ITEM_GENRE, value); - } else if (0 == strcasecmp("date", item)) { + } else if (0 == g_ascii_strcasecmp("date", item)) { tag_add_item(ret, TAG_ITEM_DATE, value); - } else if (0 == strcasecmp("writer", item)) { + } else if (0 == g_ascii_strcasecmp("writer", item)) { tag_add_item(ret, TAG_ITEM_COMPOSER, value); } |