diff options
| author | Warren Dukes <warren.dukes@gmail.com> | 2004-02-25 18:46:41 +0000 |
|---|---|---|
| committer | Warren Dukes <warren.dukes@gmail.com> | 2004-02-25 18:46:41 +0000 |
| commit | e4f265b2fce5609d4862cd2d42fd58adf7341299 (patch) | |
| tree | 1ce9c5b2589f06d2138a060802124cb19b458881 /src/decode.c | |
| parent | ca3068d411dc60bf6de2eb88f73c6f91486e8260 (diff) | |
| download | mpd-e4f265b2fce5609d4862cd2d42fd58adf7341299.tar.gz mpd-e4f265b2fce5609d4862cd2d42fd58adf7341299.tar.xz mpd-e4f265b2fce5609d4862cd2d42fd58adf7341299.zip | |
be more careful with string manipulations, use strncpy as much as possible
git-svn-id: https://svn.musicpd.org/mpd/trunk@56 09075e82-0dd4-0310-85a5-a0d7c8717e4f
Diffstat (limited to '')
| -rw-r--r-- | src/decode.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/decode.c b/src/decode.c index 80789337e..ecedc330a 100644 --- a/src/decode.c +++ b/src/decode.c @@ -108,14 +108,14 @@ int waitOnDecode(PlayerControl * pc, AudioFormat * af, DecoderControl * dc, while(decode_pid>0 && dc->start) usleep(10); if(dc->start || dc->error!=DECODE_ERROR_NOERROR) { - strcpy(pc->erroredFile,pc->file); + strncpy(pc->erroredFile,pc->file,MAXPATHLEN); pc->error = PLAYER_ERROR_FILE; quitDecode(pc,dc); return -1; } if(initAudio(af)<0) { - strcpy(pc->erroredFile,pc->file); + strncpy(pc->erroredFile,pc->file,MAXPATHLEN); pc->error = PLAYER_ERROR_AUDIO; quitDecode(pc,dc); return -1; @@ -196,7 +196,7 @@ int decoderInit(PlayerControl * pc, Buffer * cb, AudioFormat *af, while(1) { if(dc->start) { - strcpy(dc->file,pc->file); + strncpy(dc->file,pc->file,MAXPATHLEN); switch(pc->decodeType) { #ifdef HAVE_MAD case DECODE_TYPE_MP3: @@ -239,7 +239,7 @@ int decoderInit(PlayerControl * pc, Buffer * cb, AudioFormat *af, /* END OF CHILD */ } else if(decode_pid<0) { - strcpy(pc->erroredFile,pc->file); + strncpy(pc->erroredFile,pc->file,MAXPATHLEN); pc->error = PLAYER_ERROR_SYSTEM; return -1; } |