aboutsummaryrefslogtreecommitdiffstats
path: root/src/conf.c
diff options
context:
space:
mode:
authorMax Kellermann <max@duempel.org>2011-09-09 21:06:23 +0200
committerMax Kellermann <max@duempel.org>2011-09-09 21:36:35 +0200
commite3eca82cc3b3c3fd0b8557c1ec9ae99d1532b054 (patch)
tree825574ff1ee464702f37cd78aea499ab7d8923da /src/conf.c
parente7651d0d0f989298308cfd579ca76e294ede722e (diff)
downloadmpd-e3eca82cc3b3c3fd0b8557c1ec9ae99d1532b054.tar.gz
mpd-e3eca82cc3b3c3fd0b8557c1ec9ae99d1532b054.tar.xz
mpd-e3eca82cc3b3c3fd0b8557c1ec9ae99d1532b054.zip
conf: move code to config_read_name_value()
Reduce indent.
Diffstat (limited to '')
-rw-r--r--src/conf.c66
1 files changed, 34 insertions, 32 deletions
diff --git a/src/conf.c b/src/conf.c
index a79750477..ee5aaceb3 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -254,16 +254,47 @@ config_add_block_param(struct config_param * param, const char *name,
return true;
}
+static bool
+config_read_name_value(struct config_param *param, char *input, unsigned line,
+ GError **error_r)
+{
+ const char *name = tokenizer_next_word(&input, error_r);
+ if (name == NULL) {
+ assert(*input != 0);
+ return false;
+ }
+
+ const char *value = tokenizer_next_string(&input, error_r);
+ if (value == NULL) {
+ if (*input == 0) {
+ assert(error_r == NULL || *error_r == NULL);
+ g_set_error(error_r, config_quark(), 0,
+ "Value missing");
+ } else {
+ assert(error_r == NULL || *error_r != NULL);
+ }
+
+ return false;
+ }
+
+ if (*input != 0 && *input != CONF_COMMENT) {
+ g_set_error(error_r, config_quark(), 0,
+ "Unknown tokens after value");
+ return false;
+ }
+
+ return config_add_block_param(param, name, value, line,
+ error_r);
+}
+
static struct config_param *
config_read_block(FILE *fp, int *count, char *string, GError **error_r)
{
struct config_param *ret = config_new_param(NULL, *count);
GError *error = NULL;
- bool success;
while (true) {
char *line;
- const char *name, *value;
line = fgets(string, MAX_STRING_SIZE, fp);
if (line == NULL) {
@@ -296,42 +327,13 @@ config_read_block(FILE *fp, int *count, char *string, GError **error_r)
/* parse name and value */
- name = tokenizer_next_word(&line, &error);
- if (name == NULL) {
+ if (!config_read_name_value(ret, line, *count, &error)) {
assert(*line != 0);
config_param_free(ret);
g_propagate_prefixed_error(error_r, error,
"line %i: ", *count);
return NULL;
}
-
- value = tokenizer_next_string(&line, &error);
- if (value == NULL) {
- config_param_free(ret);
- if (*line == 0)
- g_set_error(error_r, config_quark(), 0,
- "line %i: Value missing", *count);
- else
- g_propagate_prefixed_error(error_r, error,
- "line %i: ",
- *count);
- return NULL;
- }
-
- if (*line != 0 && *line != CONF_COMMENT) {
- config_param_free(ret);
- g_set_error(error_r, config_quark(), 0,
- "line %i: Unknown tokens after value",
- *count);
- return NULL;
- }
-
- success = config_add_block_param(ret, name, value, *count,
- error_r);
- if (!success) {
- config_param_free(ret);
- return false;
- }
}
}