diff options
| author | Max Kellermann <max@duempel.org> | 2009-03-14 11:10:21 +0100 |
|---|---|---|
| committer | Max Kellermann <max@duempel.org> | 2009-03-14 11:10:21 +0100 |
| commit | f15d879e37985224aa4780a9de6b81d2df781ed6 (patch) | |
| tree | ee5d242add0bd917077df92f5e6ee0d5cfc08cad /src/command.c | |
| parent | f31c371fbd95d1999b18c6b35596d8f3b71b620c (diff) | |
| download | mpd-f15d879e37985224aa4780a9de6b81d2df781ed6.tar.gz mpd-f15d879e37985224aa4780a9de6b81d2df781ed6.tar.xz mpd-f15d879e37985224aa4780a9de6b81d2df781ed6.zip | |
volume: use bool instead of int
Return true/false on success/failure, instead of 0/-1. Pass
true/false instead of 1/0 for the "rel" boolean parameter.
Diffstat (limited to '')
| -rw-r--r-- | src/command.c | 22 |
1 files changed, 14 insertions, 8 deletions
diff --git a/src/command.c b/src/command.c index 1a019b830..535c3638c 100644 --- a/src/command.c +++ b/src/command.c @@ -1039,33 +1039,39 @@ handle_listall(struct client *client, G_GNUC_UNUSED int argc, char *argv[]) static enum command_return handle_volume(struct client *client, G_GNUC_UNUSED int argc, char *argv[]) { - int change, ret; + int change; + bool success; if (!check_int(client, &change, argv[1], need_integer)) return COMMAND_RETURN_ERROR; - ret = volume_level_change(change, 1); - if (ret == -1) + success = volume_level_change(change, true); + if (!success) { command_error(client, ACK_ERROR_SYSTEM, "problems setting volume"); + return COMMAND_RETURN_ERROR; + } - return ret; + return COMMAND_RETURN_OK; } static enum command_return handle_setvol(struct client *client, G_GNUC_UNUSED int argc, char *argv[]) { - int level, ret; + int level; + bool success; if (!check_int(client, &level, argv[1], need_integer)) return COMMAND_RETURN_ERROR; - ret = volume_level_change(level, 0); - if (ret == -1) + success = volume_level_change(level, 0); + if (!success) { command_error(client, ACK_ERROR_SYSTEM, "problems setting volume"); + return COMMAND_RETURN_ERROR; + } - return ret; + return COMMAND_RETURN_OK; } static enum command_return |