aboutsummaryrefslogtreecommitdiffstats
path: root/src/client.c
diff options
context:
space:
mode:
authorMax Kellermann <max@duempel.org>2008-08-28 20:03:03 +0200
committerEric Wong <normalperson@yhbt.net>2008-09-01 18:35:18 -0700
commit1e6af706599c733a707e9fd32f0ef733d1908362 (patch)
tree752491d032840ceb3184196c96483f5999437893 /src/client.c
parent9cf1bf0671950024a21918335ab82ce9ef24cbf7 (diff)
downloadmpd-1e6af706599c733a707e9fd32f0ef733d1908362.tar.gz
mpd-1e6af706599c733a707e9fd32f0ef733d1908362.tar.xz
mpd-1e6af706599c733a707e9fd32f0ef733d1908362.zip
client: return early in client_new()
This saves one level of indent.
Diffstat (limited to 'src/client.c')
-rw-r--r--src/client.c61
1 files changed, 31 insertions, 30 deletions
diff --git a/src/client.c b/src/client.c
index 87088e76f..54c62bc83 100644
--- a/src/client.c
+++ b/src/client.c
@@ -237,6 +237,7 @@ static void client_close(struct client *client)
void client_new(int fd, const struct sockaddr *addr)
{
unsigned int i;
+ const char *hostname;
for (i = 0; i < client_max_connections
&& clients[i].fd >= 0; i++) /* nothing */ ;
@@ -244,44 +245,44 @@ void client_new(int fd, const struct sockaddr *addr)
if (i == client_max_connections) {
ERROR("Max Connections Reached!\n");
xclose(fd);
- } else {
- const char *hostname;
- switch (addr->sa_family) {
+ return;
+ }
+
+ switch (addr->sa_family) {
#ifdef HAVE_TCP
- case AF_INET:
- hostname = (const char *)inet_ntoa(((const struct sockaddr_in *)
- addr)->sin_addr);
- if (!hostname)
- hostname = "error getting ipv4 address";
- break;
+ case AF_INET:
+ hostname = (const char *)inet_ntoa(((const struct sockaddr_in *)
+ addr)->sin_addr);
+ if (!hostname)
+ hostname = "error getting ipv4 address";
+ break;
#ifdef HAVE_IPV6
- case AF_INET6:
- {
- static char host[INET6_ADDRSTRLEN + 1];
- memset(host, 0, INET6_ADDRSTRLEN + 1);
- if (inet_ntop(AF_INET6, (const void *)
- &(((const struct sockaddr_in6 *)addr)->
- sin6_addr), host,
- INET6_ADDRSTRLEN)) {
- hostname = (const char *)host;
- } else {
- hostname = "error getting ipv6 address";
- }
+ case AF_INET6:
+ {
+ static char host[INET6_ADDRSTRLEN + 1];
+ memset(host, 0, INET6_ADDRSTRLEN + 1);
+ if (inet_ntop(AF_INET6, (const void *)
+ &(((const struct sockaddr_in6 *)addr)->
+ sin6_addr), host,
+ INET6_ADDRSTRLEN)) {
+ hostname = (const char *)host;
+ } else {
+ hostname = "error getting ipv6 address";
}
- break;
+ }
+ break;
#endif
#endif /* HAVE_TCP */
#ifdef HAVE_UN
- case AF_UNIX:
- hostname = "local connection";
- break;
+ case AF_UNIX:
+ hostname = "local connection";
+ break;
#endif /* HAVE_UN */
- default:
- hostname = "unknown";
- }
- SECURE("client %i: opened from %s\n", i, hostname);
- client_init(&(clients[i]), fd);
+ default:
+ hostname = "unknown";
}
+ SECURE("client %i: opened from %s\n", i, hostname);
+ client_init(&(clients[i]), fd);
}
static int client_process_line(struct client *client)