aboutsummaryrefslogtreecommitdiffstats
path: root/src/archive
diff options
context:
space:
mode:
authorMax Kellermann <max@duempel.org>2009-10-11 23:32:22 +0200
committerMax Kellermann <max@duempel.org>2009-10-11 23:32:22 +0200
commit727c301fbcd285ff781f2d9b538973ca6a4ebcef (patch)
treef75711b0035fdfb1e3a4f3e529ef5ffd9ef81d45 /src/archive
parent71f881d5cb40fbb77a77a8b50b8d662acaa84310 (diff)
downloadmpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.tar.gz
mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.tar.xz
mpd-727c301fbcd285ff781f2d9b538973ca6a4ebcef.zip
input_stream: use "goffset" instead of "off_t"
The "off_t" type may change when you enable or disable large file support on 32 bit platforms. This caused severe ABI problems within MPD when we enabled LFS for the first time: two sources included config.h and sys/types.h in different order, and had different off_t sizes - leading to memory corruption because of ABI incompatibility. This patch attempts to get rid of all public "off_t" uses: it removes "off_t" from the input_stream ABI/API, and switches to GLib's 64 bit "goffset" type. This may hurt 32 bit embedded platforms a tiny bit, but that's not even measurable.
Diffstat (limited to '')
-rw-r--r--src/archive/zip_plugin.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/archive/zip_plugin.c b/src/archive/zip_plugin.c
index dbd2534fa..ad3b403b4 100644
--- a/src/archive/zip_plugin.c
+++ b/src/archive/zip_plugin.c
@@ -157,7 +157,7 @@ zip_is_eof(struct input_stream *is)
static bool
zip_is_seek(G_GNUC_UNUSED struct input_stream *is,
- G_GNUC_UNUSED off_t offset, G_GNUC_UNUSED int whence)
+ G_GNUC_UNUSED goffset offset, G_GNUC_UNUSED int whence)
{
zip_context *context = (zip_context *) is->data;
zzip_off_t ofs = zzip_seek(context->file, offset, whence);