aboutsummaryrefslogtreecommitdiffstats
path: root/src/SongUpdate.cxx
diff options
context:
space:
mode:
authorMax Kellermann <max@duempel.org>2014-01-18 19:08:39 +0100
committerMax Kellermann <max@duempel.org>2014-01-19 02:58:55 +0100
commitd2cf74027c2c252181ab16c1348281c252665353 (patch)
tree50dc8efe859419ad9f266bc277049bae34790c78 /src/SongUpdate.cxx
parentbc966577ffb2354f44ebb85ceb83b188bb6907b6 (diff)
downloadmpd-d2cf74027c2c252181ab16c1348281c252665353.tar.gz
mpd-d2cf74027c2c252181ab16c1348281c252665353.tar.xz
mpd-d2cf74027c2c252181ab16c1348281c252665353.zip
Song: embed the Tag object statically into class Song
Reduces overhead because we need to manage only one memory allocation. According to valgrind/massif, we save 7%.
Diffstat (limited to '')
-rw-r--r--src/SongUpdate.cxx6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/SongUpdate.cxx b/src/SongUpdate.cxx
index 669d0568d..dd01ea7d7 100644
--- a/src/SongUpdate.cxx
+++ b/src/SongUpdate.cxx
@@ -98,8 +98,7 @@ Song::UpdateFile()
mtime = st.st_mtime;
- delete tag;
- tag = tag_builder.CommitNew();
+ tag_builder.Commit(tag);
return true;
}
@@ -123,8 +122,7 @@ Song::UpdateFileInArchive()
if (!tag_stream_scan(path_fs.c_str(), full_tag_handler, &tag_builder))
return false;
- delete tag;
- tag = tag_builder.CommitNew();
+ tag_builder.Commit(tag);
return true;
}