diff options
| author | Max Kellermann <max@duempel.org> | 2008-04-12 04:12:11 +0000 |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2008-04-12 04:12:11 +0000 |
| commit | 199ea5f2c1bf76846e28b1283c537a01a85dd0b6 (patch) | |
| tree | 5fc1854c0646f892ae58624e6523d2e10b68bead | |
| parent | e63f388b046a9cc71e3353581b1f34d9975b3ba0 (diff) | |
| download | mpd-199ea5f2c1bf76846e28b1283c537a01a85dd0b6.tar.gz mpd-199ea5f2c1bf76846e28b1283c537a01a85dd0b6.tar.xz mpd-199ea5f2c1bf76846e28b1283c537a01a85dd0b6.zip | |
do not check dc->start after loop
dc->start cannot be true after the loop, because it was the loop
condition. dc->start could have been set by another thread between
the while loop and the if, but I suspect this is not the case the
author intended, so we just remove the dc->start check.
git-svn-id: https://svn.musicpd.org/mpd/trunk@7256 09075e82-0dd4-0310-85a5-a0d7c8717e4f
| -rw-r--r-- | src/decode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/decode.c b/src/decode.c index 98bcae6a5..668d08365 100644 --- a/src/decode.c +++ b/src/decode.c @@ -144,7 +144,7 @@ static int waitOnDecode(PlayerControl * pc, DecoderControl * dc, while (dc->start) player_wakeup_decoder(); - if (dc->start || dc->error != DECODE_ERROR_NOERROR) { + if (dc->error != DECODE_ERROR_NOERROR) { pc->errored_song = pc->current_song; pc->error = PLAYER_ERROR_FILE; quitDecode(pc, dc); |