diff options
| author | Max Kellermann <max@duempel.org> | 2008-09-10 11:42:30 +0200 |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2008-09-10 23:34:54 -0700 |
| commit | 929e0e6d351a4a231d3b7aeb08df571be5d3b949 (patch) | |
| tree | 7f5634e90339d5f743c6aed8edfcca5f2ba67672 | |
| parent | 70199776b4c925268105df7998905ee36c79846b (diff) | |
| download | mpd-929e0e6d351a4a231d3b7aeb08df571be5d3b949.tar.gz mpd-929e0e6d351a4a231d3b7aeb08df571be5d3b949.tar.xz mpd-929e0e6d351a4a231d3b7aeb08df571be5d3b949.zip | |
client: client_input_received() returns 0
Since the caller chain doesn't care about the return value (except for
COMMAND_RETURN_KILL, COMMAND_RETURN_CLOSE), just return 0 if there is
nothing special. This saves one local variable initialization, and
one access to it.
Also remove one unreachable "return 1" from client_read().
| -rw-r--r-- | src/client.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/client.c b/src/client.c index 03e9ad0dc..381b4713b 100644 --- a/src/client.c +++ b/src/client.c @@ -400,7 +400,7 @@ static int client_process_line(struct client *client) static int client_input_received(struct client *client, int bytesRead) { - int ret = 0; + int ret; char *buf_tail = &(client->buffer[client->bufferLength - 1]); while (bytesRead > 0) { @@ -440,7 +440,7 @@ static int client_input_received(struct client *client, int bytesRead) } } - return ret; + return 0; } static int client_read(struct client *client) @@ -457,8 +457,6 @@ static int client_read(struct client *client) return COMMAND_RETURN_CLOSE; } else return 0; - - return 1; } static void client_manager_register_read_fd(fd_set * fds, int *fdmax) |