From 25244ce18f64ece0781b0d7a3484e9c59f2ada98 Mon Sep 17 00:00:00 2001 From: Mark Sapiro Date: Thu, 28 Mar 2013 15:43:27 -0700 Subject: The subscribe log entry for a bin/add_members subscribe now identifies bin/add_members as the source. (LP: 1161642) --- bin/add_members | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'bin') diff --git a/bin/add_members b/bin/add_members index 13321935..a471919e 100755 --- a/bin/add_members +++ b/bin/add_members @@ -1,6 +1,6 @@ #! @PYTHON@ # -# Copyright (C) 1998-2010 by the Free Software Foundation, Inc. +# Copyright (C) 1998-2013 by the Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License @@ -137,7 +137,11 @@ def addall(mlist, members, digest, ack, outfp, nomail): userdesc.digest = digest try: - mlist.ApprovedAddMember(userdesc, ack, 0) + mlist.ApprovedAddMember(userdesc, + ack=ack, + admin_notif=False, + whence='bin/add_members', + ) except Errors.MMAlreadyAMember: print >> tee, _('Already a member: %(member)s') except Errors.MembershipIsBanned, pattern: -- cgit v1.2.3 From 34d5cbf83819f464d365ec7ecb731f94771bf446 Mon Sep 17 00:00:00 2001 From: Mark Sapiro Date: Mon, 10 Jun 2013 14:35:21 -0700 Subject: - Fixed bin/mailmanctl -s to not remove the master lock if it can't be determined to be truly stale. (LP: #1189558) --- bin/mailmanctl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'bin') diff --git a/bin/mailmanctl b/bin/mailmanctl index 9330cfa8..fa14a2cd 100644 --- a/bin/mailmanctl +++ b/bin/mailmanctl @@ -1,6 +1,6 @@ #! @PYTHON@ -# Copyright (C) 2001-2012 by the Free Software Foundation, Inc. +# Copyright (C) 2001-2013 by the Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License @@ -199,7 +199,8 @@ def acquire_lock_1(force): lock.lock(0.1) return lock except LockFile.TimeOutError: - if not force: + # If we're not forcing or the lock can't be determined to be stale. + if not force or qrunner_state(): raise # Force removal of lock first lock._disown() -- cgit v1.2.3 From e80d72c40923b082f5e113b2d732f679c7e8b632 Mon Sep 17 00:00:00 2001 From: Mark Sapiro Date: Fri, 12 Jul 2013 14:03:26 -0700 Subject: - Added more explanation to the bad owner address message from bin/newlist. (LP: #1200763) --- bin/newlist | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'bin') diff --git a/bin/newlist b/bin/newlist index c14b77f3..940ca9f4 100755 --- a/bin/newlist +++ b/bin/newlist @@ -204,7 +204,9 @@ def main(): except Errors.BadListNameError, s: usage(1, _('Illegal list name: %(s)s')) except Errors.EmailAddressError, s: - usage(1, _('Bad owner email address: %(s)s')) + usage(1, _('Bad owner email address: %(s)s') + + _(' - owner addresses need to be fully-qualified names' + ' like "owner@example.com", not just "owner".')) except Errors.MMListAlreadyExistsError: usage(1, _('List already exists: %(listname)s')) -- cgit v1.2.3 From c2f599fd9b708faf45d8dd621cdd89cc814f60d5 Mon Sep 17 00:00:00 2001 From: Mark Sapiro Date: Tue, 22 Oct 2013 11:16:35 -0700 Subject: Fixed a possible UnicodeDecodeError in bin/sync_members. --- bin/sync_members | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'bin') diff --git a/bin/sync_members b/bin/sync_members index 13d0b2b0..58262841 100755 --- a/bin/sync_members +++ b/bin/sync_members @@ -1,6 +1,6 @@ #! @PYTHON@ # -# Copyright (C) 1998-2003 by the Free Software Foundation, Inc. +# Copyright (C) 1998-2013 by the Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License @@ -256,6 +256,8 @@ def main(): try: if not dryrun: mlist.ApprovedAddMember(userdesc, welcome, notifyadmin) + # Avoid UnicodeError if name can't be decoded + name = unicode(name, errors='replace').encode(enc, 'replace') s = email.Utils.formataddr((name, addr)).encode(enc, 'replace') print _('Added : %(s)s') except Errors.MMAlreadyAMember: @@ -276,6 +278,8 @@ def main(): # reasons is in the database. Use a lower level remove to # get rid of this member's entry mlist.removeMember(addr) + # Avoid UnicodeError if name can't be decoded + name = unicode(name, errors='replace').encode(enc, 'replace') s = email.Utils.formataddr((name, addr)).encode(enc, 'replace') print _('Removed: %(s)s') -- cgit v1.2.3