aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Mailman/Cgi/listinfo.py2
-rw-r--r--Mailman/Utils.py5
-rwxr-xr-xNEWS4
3 files changed, 9 insertions, 2 deletions
diff --git a/Mailman/Cgi/listinfo.py b/Mailman/Cgi/listinfo.py
index 4de5ccea..c13fdb26 100644
--- a/Mailman/Cgi/listinfo.py
+++ b/Mailman/Cgi/listinfo.py
@@ -190,7 +190,7 @@ def list_listinfo(mlist, lang):
remote = os.environ.get('HTTP_FORWARDED_FOR',
os.environ.get('HTTP_X_FORWARDED_FOR',
os.environ.get('REMOTE_ADDR',
- 'w.x.y.z'))
+ 'w.x.y.z')))
# Try to accept a range in case of load balancers, etc. (LP: #1447445)
if remote.find('.') >= 0:
# ipv4 - drop last octet
diff --git a/Mailman/Utils.py b/Mailman/Utils.py
index 36c08aaf..fe513c8e 100644
--- a/Mailman/Utils.py
+++ b/Mailman/Utils.py
@@ -266,7 +266,10 @@ def GetPathPieces(envar='PATH_INFO'):
os.environ.get('HTTP_X_FORWARDED_FOR',
os.environ.get('REMOTE_ADDR',
'unidentified origin')))
- syslog('error', 'Warning: Possible malformed path attack domain=%s remote=%s' % get_domain(), remote)
+ syslog('error',
+ 'Warning: Possible malformed path attack domain=%s remote=%s',
+ get_domain(),
+ remote)
return [p for p in path.split('/') if p]
return None
diff --git a/NEWS b/NEWS
index cb7eb2ba..623d830b 100755
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,10 @@ Here is a history of user visible changes to Mailman.
Bug fixes and other patches
+ - Improved identification of remote clients for logging and subscribe
+ form checking in cases where access is via a proxy server. Thanks to
+ Jim Popovitch.
+
- Fixed an issue with shunted messages on a list where the charset for
the list's preferred_language had been changed from iso-8859-1 to
utf-8 without recoding the list's description. (LP: #1462755)