aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Mailman/Queue/Switchboard.py18
-rw-r--r--NEWS4
2 files changed, 17 insertions, 5 deletions
diff --git a/Mailman/Queue/Switchboard.py b/Mailman/Queue/Switchboard.py
index 52c430b0..17046a8c 100644
--- a/Mailman/Queue/Switchboard.py
+++ b/Mailman/Queue/Switchboard.py
@@ -1,4 +1,4 @@
-# Copyright (C) 2001-2004 by the Free Software Foundation, Inc.
+# Copyright (C) 2001-2006 by the Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
@@ -12,7 +12,8 @@
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
+# USA.
"""Reading and writing message objects and message metadata.
"""
@@ -59,6 +60,9 @@ except NameError:
# (when False). Pickles are more efficient because the message doesn't need
# to be re-parsed every time it's unqueued, but pickles are not human readable.
SAVE_MSGS_AS_PICKLES = True
+# Small increment to add to time in case two entries have the same time. This
+# prevents skipping one of two entries with the same time until the next pass.
+DELTA = .0001
@@ -163,9 +167,13 @@ class Switchboard:
filebase = os.path.splitext(f)[0]
when, digest = filebase.split('+')
# Throw out any files which don't match our bitrange. BAW: test
- # performance and end-cases of this algorithm.
- if lower is None or (lower <= long(digest, 16) < upper):
- times[float(when)] = filebase
+ # performance and end-cases of this algorithm. MAS: both
+ # comparisons need to be <= to get complete range.
+ if lower is None or (lower <= long(digest, 16) <= upper):
+ key = float(when)
+ while times.has_key(key):
+ key += DELTA
+ times[key] = filebase
# FIFO sort
keys = times.keys()
keys.sort()
diff --git a/NEWS b/NEWS
index 491ff644..7e46501f 100644
--- a/NEWS
+++ b/NEWS
@@ -18,6 +18,10 @@ Here is a history of user visible changes to Mailman.
- Fixed Decorate.py so that characters in message header/footer which
are not in the character set of the list's language are ignored rather
than causing shunted messages (1507248).
+
+ - Switchboard.py - Closed very tiny holes at the upper ends of queue
+ slices that could result in unprocessable queue entries. Improved FIFO
+ processing when two queue entries have the same timestamp.
2.1.8 (15-Apr-2006)