aboutsummaryrefslogtreecommitdiffstats
path: root/Mailman/Cgi
diff options
context:
space:
mode:
authorbwarsaw <>2003-12-24 17:27:45 +0000
committerbwarsaw <>2003-12-24 17:27:45 +0000
commita2e03dd6bfd25d4cd070b17f03c708e588db65e8 (patch)
tree2a2578b70feaf061de1a9d2f404aa20a7c8ef33b /Mailman/Cgi
parent29ece88fcc1dbc64ec01779b4cf9e401a01d04ec (diff)
downloadmailman2-a2e03dd6bfd25d4cd070b17f03c708e588db65e8.tar.gz
mailman2-a2e03dd6bfd25d4cd070b17f03c708e588db65e8.tar.xz
mailman2-a2e03dd6bfd25d4cd070b17f03c708e588db65e8.zip
adminy_overview(): Richard Barrett's patch # 828811 to reduce listinfo
and admin cgi process size by not keeping the entire mlist object alive through a reference in the advertised list. Only the information used in the overview is kept.
Diffstat (limited to 'Mailman/Cgi')
-rw-r--r--Mailman/Cgi/admin.py11
1 files changed, 6 insertions, 5 deletions
diff --git a/Mailman/Cgi/admin.py b/Mailman/Cgi/admin.py
index c0c2a542..cbe0a410 100644
--- a/Mailman/Cgi/admin.py
+++ b/Mailman/Cgi/admin.py
@@ -238,8 +238,9 @@ def admin_overview(msg=''):
# List is for different identity of this host - skip it.
continue
else:
- advertised.append(mlist)
-
+ advertised.append((mlist.GetScriptURL('admin'),
+ mlist.real_name,
+ mlist.description))
# Greeting depends on whether there was an error or not
if msg:
greeting = FontAttr(msg, color="ff5060", size="+1")
@@ -289,10 +290,10 @@ def admin_overview(msg=''):
Bold(FontAttr(_('Description'), size='+2'))
])
highlight = 1
- for mlist in advertised:
+ for url, real_name, description in advertised:
table.AddRow(
- [Link(mlist.GetScriptURL('admin'), Bold(mlist.real_name)),
- mlist.description or Italic(_('[no description available]'))])
+ [Link(url, Bold(real_name)),
+ description or Italic(_('[no description available]'))])
if highlight and mm_cfg.WEB_HIGHLIGHT_COLOR:
table.AddRowInfo(table.GetCurrentRowIndex(),
bgcolor=mm_cfg.WEB_HIGHLIGHT_COLOR)