aboutsummaryrefslogtreecommitdiffstats
path: root/Mailman/Cgi/rmlist.py
diff options
context:
space:
mode:
authorMark Sapiro <mark@msapiro.net>2016-07-14 14:27:49 -0700
committerMark Sapiro <mark@msapiro.net>2016-07-14 14:27:49 -0700
commit6efea059931995de8713f35bccc1116905175cf2 (patch)
tree6f7933394fc09ef5e495b24a558ca9c2a5f983f0 /Mailman/Cgi/rmlist.py
parentde6ffbe5a0ce37751247b071b75aa7c8e6605c58 (diff)
downloadmailman2-6efea059931995de8713f35bccc1116905175cf2.tar.gz
mailman2-6efea059931995de8713f35bccc1116905175cf2.tar.xz
mailman2-6efea059931995de8713f35bccc1116905175cf2.zip
Catch TypeError from certain defective crafted POST requests.
Diffstat (limited to 'Mailman/Cgi/rmlist.py')
-rw-r--r--Mailman/Cgi/rmlist.py13
1 files changed, 12 insertions, 1 deletions
diff --git a/Mailman/Cgi/rmlist.py b/Mailman/Cgi/rmlist.py
index db588121..3149700d 100644
--- a/Mailman/Cgi/rmlist.py
+++ b/Mailman/Cgi/rmlist.py
@@ -1,4 +1,4 @@
-# Copyright (C) 2001-2014 by the Free Software Foundation, Inc.
+# Copyright (C) 2001-2016 by the Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
@@ -41,6 +41,17 @@ def main():
doc.set_language(mm_cfg.DEFAULT_SERVER_LANGUAGE)
cgidata = cgi.FieldStorage()
+ try:
+ cgidata.getvalue('password', '')
+ except TypeError:
+ # Someone crafted a POST with a bad Content-Type:.
+ doc.AddItem(Header(2, _("Error")))
+ doc.AddItem(Bold(_('Invalid options to CGI script.')))
+ # Send this with a 400 status.
+ print 'Status: 400 Bad Request'
+ print doc.Format()
+ return
+
parts = Utils.GetPathPieces()
if not parts: