Vette log entries for banned subscriptions now include the source of

the request if available.

2 files changed, 8 insertions, 2 deletions

diff --git a/Mailman/MailList.py b/Mailman/MailList.py
index b76dfa1f..0d47d812 100755
--- a/Mailman/MailList.py
+++ b/Mailman/MailList.py
@@ -883,8 +883,12 @@ class MailList(HTMLFormatter, Deliverer, ListAdmin,
         # Is the subscribing address banned from this list?
         pattern = self.GetBannedPattern(email)
         if pattern:
-            syslog('vette', '%s banned subscription: %s (matched: %s)',
-                   realname, email, pattern)
+            if remote:
+                whence = ' from %s' % remote
+            else:
+                whence = ''
+            syslog('vette', '%s banned subscription: %s%s (matched: %s)',
+                   realname, email, whence, pattern)
             raise Errors.MembershipIsBanned, pattern
         # Sanity check the digest flag
         if digest and not self.digestable:
diff --git a/NEWS b/NEWS
index 94014633..254d6047 100755
--- a/NEWS
+++ b/NEWS
@@ -21,6 +21,8 @@ Here is a history of user visible changes to Mailman.
       de Mello.
 
   Bug fixes and other patches
+    - Vette log entries for banned subscriptions now include the source of
+      the request if available.  (LP: #1525733)
 
     - Submitting the user options form for a user who was asynchronously
       unsubscribed would throw an uncaught NotAMemberError.  (LP: #1523273)