aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Sapiro <mark@msapiro.net>2016-10-27 15:37:37 -0700
committerMark Sapiro <mark@msapiro.net>2016-10-27 15:37:37 -0700
commit662f43897a36654177b351ffa2075d6a8039dd5b (patch)
tree93db571b896bec853c2af07b9f5476fd145fd0c0
parentd741efd05e8a5cba80f22e0b5df4f71b7b858781 (diff)
downloadmailman2-662f43897a36654177b351ffa2075d6a8039dd5b.tar.gz
mailman2-662f43897a36654177b351ffa2075d6a8039dd5b.tar.xz
mailman2-662f43897a36654177b351ffa2075d6a8039dd5b.zip
Fixed incorrect "view more members" links at the bottom of the admin
Membership List pages.
-rw-r--r--Mailman/Cgi/admin.py9
-rw-r--r--NEWS3
2 files changed, 8 insertions, 4 deletions
diff --git a/Mailman/Cgi/admin.py b/Mailman/Cgi/admin.py
index 843f6e08..736cc684 100644
--- a/Mailman/Cgi/admin.py
+++ b/Mailman/Cgi/admin.py
@@ -1188,11 +1188,12 @@ def membership_options(mlist, subcat, cgidata, doc, form):
continue
start = chunkmembers[i*chunksz]
end = chunkmembers[min((i+1)*chunksz, last)-1]
- url = url + 'chunk=%d' % i + findfrag
- if isinstance(url, unicode):
- url = url.encode(Utils.GetCharSet(mlist.preferred_language),
+ thisurl = url + 'chunk=%d' % i + findfrag
+ if isinstance(thisurl, unicode):
+ thisurl = thisurl.encode(
+ Utils.GetCharSet(mlist.preferred_language),
errors='ignore')
- link = Link(url, _('from %(start)s to %(end)s'))
+ link = Link(thisurl, _('from %(start)s to %(end)s'))
buttons.append(link)
buttons = UnorderedList(*buttons)
container.AddItem(footer + buttons.Format() + '<p>')
diff --git a/NEWS b/NEWS
index bd8320b1..3f06cead 100644
--- a/NEWS
+++ b/NEWS
@@ -23,6 +23,9 @@ Here is a history of user visible changes to Mailman.
Bug fixes and other patches
+ - Fixed a bug which created incorrect "view more members" links at the
+ bottom of the admin Membership List pages. (LP: #1637061)
+
- The 2.1.23 fix for LP: #1604544 only fixed the letter links at the top
of the Membership List. The links at the bottom have now been fixed.