Mailman's log files, request.pck files and heldmsg-* files are no

longer created world readable to protect against access by untrusted
local users.

3 files changed, 14 insertions, 5 deletions

diff --git a/Mailman/ListAdmin.py b/Mailman/ListAdmin.py
index a4edfbba..877aa5c4 100755
--- a/Mailman/ListAdmin.py
+++ b/Mailman/ListAdmin.py
@@ -101,7 +101,7 @@ class ListAdmin:
             # should we be as paranoid as for the config.pck file?  Should we
             # use pickle?
             tmpfile = self.__filename + '.tmp'
-            omask = os.umask(002)
+            omask = os.umask(007)
             try:
                 fp = open(tmpfile, 'w')
                 try:
@@ -194,7 +194,7 @@ class ListAdmin:
         else:
             ext = 'txt'
         filename = 'heldmsg-%s-%d.%s' % (self.internal_name(), id, ext)
-        omask = os.umask(002)
+        omask = os.umask(007)
         try:
             fp = open(os.path.join(mm_cfg.DATA_DIR, filename), 'w')
             try:
diff --git a/Mailman/Logging/Logger.py b/Mailman/Logging/Logger.py
index 617347d4..f3d30164 100644
--- a/Mailman/Logging/Logger.py
+++ b/Mailman/Logging/Logger.py
@@ -60,7 +60,7 @@ class Logger:
             return self.__fp
         else:
             try:
-                ou = os.umask(002)
+                ou = os.umask(007)
                 try:
                     try:
                         f = codecs.open(
diff --git a/NEWS b/NEWS
index c7f562a5..bd554729 100755
--- a/NEWS
+++ b/NEWS
@@ -7,11 +7,20 @@ Here is a history of user visible changes to Mailman.
 
 2.1.19 (xx-xxx-xxxx)
 
+  Changed behavior
+
+    - Mailman's log files, request.pck files and heldmsg-* files are no
+      longer created world readable to protect against access by untrusted
+      local users.  Note that permissions on existing log files won't be
+      changed so if you are concerned about this and don't rotate logs or
+      have a logrotate process that creates new log files instead of letting
+      Mailman create them, you will need to address that.  (LP: #1327404)
+
+  Bug fixes and other patches
+
     - If checking DNS for dmarc_moderation_action and DNS lookup is not
       available, log it.  (LP: #1324541)
  
-  Bug fixes and other patches
-
     - Handle missing From: header addresses for DMARC mitigation actions.
       (LP: #1318025)