aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMax Kellermann <max@duempel.org>2012-10-02 00:00:56 +0200
committerMax Kellermann <max@duempel.org>2012-10-02 00:20:42 +0200
commitd34e55c370db54ace2543d9801d360dae8e7c494 (patch)
tree2e947e4ceb98610c3d40579b8157dc1b5273e66e
parentfbcbcdc0011949339666b2567c987156d47197e8 (diff)
downloadmpd-d34e55c370db54ace2543d9801d360dae8e7c494.tar.gz
mpd-d34e55c370db54ace2543d9801d360dae8e7c494.tar.xz
mpd-d34e55c370db54ace2543d9801d360dae8e7c494.zip
output/recorder: fix write() error check
We can only check for negative values if the variable is signed.
-rw-r--r--NEWS1
-rw-r--r--src/output/recorder_output_plugin.c6
2 files changed, 4 insertions, 3 deletions
diff --git a/NEWS b/NEWS
index 46963f308..a78002e97 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
ver 0.17.3 (2012/??/??)
* output:
+ - recorder: fix I/O error check
- shout: fix memory leak in error handler
ver 0.17.2 (2012/09/30)
diff --git a/src/output/recorder_output_plugin.c b/src/output/recorder_output_plugin.c
index 5d098f08f..e2366bf90 100644
--- a/src/output/recorder_output_plugin.c
+++ b/src/output/recorder_output_plugin.c
@@ -140,9 +140,9 @@ recorder_output_encoder_to_file(struct recorder_output *recorder,
size_t position = 0;
while (true) {
- size_t nbytes = write(recorder->fd,
- recorder->buffer + position,
- size - position);
+ ssize_t nbytes = write(recorder->fd,
+ recorder->buffer + position,
+ size - position);
if (nbytes > 0) {
position += (size_t)nbytes;
if (position >= size)